Bug 236276

Summary: Initialize the AXIsolatedObject AccessibilityText property lazily.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Andres Gonzalez 2022-02-07 17:51:42 PST 
Initialize the AXIsolatedObject AccessibilityText property lazily.
Comment 1 Radar WebKit Bug Importer 2022-02-07 17:52:06 PST 
<rdar://problem/88604453>
Comment 2 Andres Gonzalez 2022-02-07 18:00:05 PST 
Created attachment 451186 [details]
Patch
Comment 3 chris fleizach 2022-02-07 19:00:54 PST 
Comment on attachment 451186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451186&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011
> +    Accessibility::performFunctionOnMainThread([&propertyName, this] () {

Can these methods return a variant so we only need one method?
Comment 4 Andres Gonzalez 2022-02-08 09:10:33 PST 
Created attachment 451258 [details]
Patch
Comment 5 Andres Gonzalez 2022-02-08 09:16:13 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 451186 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451186&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011
> > +    Accessibility::performFunctionOnMainThread([&propertyName, this] () {
> 
> Can these methods return a variant so we only need one method?

Done.
Comment 6 Andres Gonzalez 2022-02-08 12:28:10 PST 
Created attachment 451294 [details]
Patch
Comment 7 EWS 2022-02-08 14:15:30 PST 
Committed r289427 (246987@main): <https://commits.webkit.org/246987@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451294 [details].