Bug 236276

Summary: Initialize the AXIsolatedObject AccessibilityText property lazily.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2022-02-07 17:51:42 PST
Initialize the AXIsolatedObject AccessibilityText property lazily.
Attachments
Patch (5.23 KB, patch)
2022-02-07 18:00 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (8.69 KB, patch)
2022-02-08 09:10 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (8.58 KB, patch)
2022-02-08 12:28 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-07 17:52:06 PST
<rdar://problem/88604453>
Andres Gonzalez
Comment 2 2022-02-07 18:00:05 PST
Created attachment 451186 [details] Patch
chris fleizach
Comment 3 2022-02-07 19:00:54 PST
Comment on attachment 451186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451186&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011 > + Accessibility::performFunctionOnMainThread([&propertyName, this] () { Can these methods return a variant so we only need one method?
Andres Gonzalez
Comment 4 2022-02-08 09:10:33 PST
Created attachment 451258 [details] Patch
Andres Gonzalez
Comment 5 2022-02-08 09:16:13 PST
(In reply to chris fleizach from comment #3) > Comment on attachment 451186 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451186&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1011 > > + Accessibility::performFunctionOnMainThread([&propertyName, this] () { > > Can these methods return a variant so we only need one method? Done.
Andres Gonzalez
Comment 6 2022-02-08 12:28:10 PST
Created attachment 451294 [details] Patch
EWS
Comment 7 2022-02-08 14:15:30 PST
Committed r289427 (246987@main): <https://commits.webkit.org/246987@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451294 [details].
Note You need to log in before you can comment on or make changes to this bug.