Bug 236271

Summary: [iOS] Take adequate process assertion for the SharedWorker process
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, darin, ggaren, kkinnunen, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230382, 236396    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2022-02-07 16:30:16 PST 
Take adequate process assertion for the SharedWorker process based on which processes rely on it.
Comment 1 Chris Dumez 2022-02-08 10:49:23 PST 
Created attachment 451274 [details]
Patch
Comment 2 Chris Dumez 2022-02-08 11:00:42 PST 
Created attachment 451277 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2022-02-08 11:32:56 PST 
<rdar://problem/88642879>
Comment 4 Chris Dumez 2022-02-08 16:51:40 PST 
Created attachment 451325 [details]
Patch
Comment 5 Chris Dumez 2022-02-09 07:12:42 PST 
Created attachment 451369 [details]
Patch
Comment 6 Chris Dumez 2022-02-09 07:19:36 PST 
Created attachment 451372 [details]
Patch
Comment 7 Chris Dumez 2022-02-09 10:43:08 PST 
Created attachment 451403 [details]
Patch
Comment 8 Chris Dumez 2022-02-09 10:51:33 PST 
Created attachment 451406 [details]
Patch
Comment 9 Brent Fulgham 2022-02-09 11:13:22 PST 
Comment on attachment 451406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451406&action=review

> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:76
> +            auto* contextConnection = sharedWorker->contextConnection();

Did SharedWorker always have the correct contextConnection, and we've been wasting time looking it up?
Comment 10 Chris Dumez 2022-02-09 11:19:13 PST 
Comment on attachment 451406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451406&action=review

>> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:76
>> +            auto* contextConnection = sharedWorker->contextConnection();
> 
> Did SharedWorker always have the correct contextConnection, and we've been wasting time looking it up?

No, technically this ends up being equivalent. I just think this looks nicer.
Comment 11 EWS 2022-02-09 16:47:52 PST 
Committed r289508 (247042@main): <https://commits.webkit.org/247042@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451406 [details].