Bug 236271

Summary: [iOS] Take adequate process assertion for the SharedWorker process
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, darin, ggaren, kkinnunen, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230382, 236396    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2022-02-07 16:30:16 PST
Take adequate process assertion for the SharedWorker process based on which processes rely on it.
Attachments
Patch (68.97 KB, patch)
2022-02-08 10:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (69.26 KB, patch)
2022-02-08 11:00 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.38 KB, patch)
2022-02-08 16:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.37 KB, patch)
2022-02-09 07:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.34 KB, patch)
2022-02-09 07:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.53 KB, patch)
2022-02-09 10:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (76.50 KB, patch)
2022-02-09 10:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-08 10:49:23 PST
Created attachment 451274 [details] Patch
Chris Dumez
Comment 2 2022-02-08 11:00:42 PST
Created attachment 451277 [details] Patch
Radar WebKit Bug Importer
Comment 3 2022-02-08 11:32:56 PST
<rdar://problem/88642879>
Chris Dumez
Comment 4 2022-02-08 16:51:40 PST
Created attachment 451325 [details] Patch
Chris Dumez
Comment 5 2022-02-09 07:12:42 PST
Created attachment 451369 [details] Patch
Chris Dumez
Comment 6 2022-02-09 07:19:36 PST
Created attachment 451372 [details] Patch
Chris Dumez
Comment 7 2022-02-09 10:43:08 PST
Created attachment 451403 [details] Patch
Chris Dumez
Comment 8 2022-02-09 10:51:33 PST
Created attachment 451406 [details] Patch
Brent Fulgham
Comment 9 2022-02-09 11:13:22 PST
Comment on attachment 451406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451406&action=review > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:76 > + auto* contextConnection = sharedWorker->contextConnection(); Did SharedWorker always have the correct contextConnection, and we've been wasting time looking it up?
Chris Dumez
Comment 10 2022-02-09 11:19:13 PST
Comment on attachment 451406 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451406&action=review >> Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:76 >> + auto* contextConnection = sharedWorker->contextConnection(); > > Did SharedWorker always have the correct contextConnection, and we've been wasting time looking it up? No, technically this ends up being equivalent. I just think this looks nicer.
EWS
Comment 11 2022-02-09 16:47:52 PST
Committed r289508 (247042@main): <https://commits.webkit.org/247042@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451406 [details].
Note You need to log in before you can comment on or make changes to this bug.