Bug 236265

Summary: Return 'none' as the computed style for mask when there are no images
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Matt Woodrow
Reported 2022-02-07 15:16:16 PST
rdar://88178304 We currently always return the full set of properties for the computed style of mask, even when there aren't any images (which matches what we do for background). To match other engines, we should just return 'none' for the case where there are no images.
Attachments
Patch (2.08 KB, patch)
2022-02-07 15:18 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (5.13 KB, patch)
2022-02-07 18:58 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (29.14 KB, patch)
2022-02-07 22:03 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2022-02-07 15:18:35 PST
Created attachment 451161 [details] Patch
Matt Woodrow
Comment 2 2022-02-07 18:58:06 PST
Created attachment 451193 [details] Patch
Matt Woodrow
Comment 3 2022-02-07 22:03:45 PST
Created attachment 451210 [details] Patch
EWS
Comment 4 2022-02-08 08:24:30 PST
Committed r289377 (246965@main): <https://commits.webkit.org/246965@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451210 [details].
Darin Adler
Comment 5 2022-02-08 08:56:03 PST
Comment on attachment 451210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451210&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.h:99 > - Ref<CSSValueList> getFillLayerPropertyShorthandValue(CSSPropertyID, const StylePropertyShorthand& propertiesBeforeSlashSeparator, const StylePropertyShorthand& propertiesAfterSlashSeparator, CSSPropertyID lastLayerProperty); > - Ref<CSSValueList> getBackgroundShorthandValue(); > - Ref<CSSValueList> getMaskShorthandValue(); > + RefPtr<CSSValue> getFillLayerPropertyShorthandValue(CSSPropertyID, const StylePropertyShorthand& propertiesBeforeSlashSeparator, const StylePropertyShorthand& propertiesAfterSlashSeparator, CSSPropertyID lastLayerProperty); > + RefPtr<CSSValue> getBackgroundShorthandValue(); > + RefPtr<CSSValue> getMaskShorthandValue(); Why the change from Ref to RefPtr? These can’t return nullptr, can they?
Matt Woodrow
Comment 6 2022-02-08 10:43:05 PST
(In reply to Darin Adler from comment #5) > Why the change from Ref to RefPtr? These can’t return nullptr, can they? Ah indeed, this is a remnant from an earlier revision of the patch, I could have left these as Ref.
Note You need to log in before you can comment on or make changes to this bug.