|Summary:||create CFString and NSString objects from WebCore::String without copying the characters|
|Product:||WebKit||Reporter:||Darin Adler <darin>|
|Component:||Platform||Assignee:||Darin Adler <darin>|
|Severity:||Normal||CC:||ap, mrowe, slewis|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Darin Adler 2009-01-29 09:50:18 PST
Mark and I realized this is possible and we think it will be a good performance optimization.
Comment 3 Darin Adler 2009-01-30 10:29:28 PST
Comment on attachment 27186 [details] patch Non-main-thread handling is wrong here. I'll have to make a new version.
Comment 4 Mark Rowe (bdash) 2009-01-30 11:54:01 PST
Comment on attachment 27186 [details] patch Shouldn't the #if PLATFORM(MAC) || !defined(BUILDING_ON_TIGER) checks have an && rather than ||?
Comment 5 Darin Adler 2009-01-30 12:14:57 PST
(In reply to comment #4) > Shouldn't the #if PLATFORM(MAC) || !defined(BUILDING_ON_TIGER) checks have an > && rather than ||? Yes. Thanks for spotting that.
Comment 6 Darin Adler 2009-01-30 17:56:38 PST
Created attachment 27205 [details] patch -- this time I think it handles threading acceptably
Comment 7 Mark Rowe (bdash) 2009-01-30 18:12:36 PST
Comment on attachment 27205 [details] patch -- this time I think it handles threading acceptably The calls to the system memory allocator should probably use FastMalloc instead, and the code may be slightly easier to follow if create() and allocator() were closer in the code. r=me
Comment 8 Darin Adler 2009-01-30 18:18:23 PST
I'm going to attach the final patch here so Stephanie can more easily do some performance testing rolling it in and out.
Comment 9 Darin Adler 2009-01-30 18:18:44 PST
Created attachment 27206 [details] final patch with changes requested by Mark