[CMake] REGRESSION(r288994): Linker does not get passed --disable-new-dtags

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

After switching from ld.gold to ld.bfd in r288994, the --disable-new-dtags
option is no longer passed to the linker. This can be an issue because without
it ELF headers will contain a DT_RUNPATH entry instead of a DT_RPATH one. The
issue is that DT_RUNPATH can be overriden by the LD_LIBRARY_PATH environment
variable, which can easily result in running binaries straight from the build
directory accidentally using libraries from outside the build directory if
the variable is defined. With DT_RPATH libraries from the lib/ subdirectory
will be used, which is desirable during testing.

[Adrian Perez]

CC'd Alex, who first noticed the issue and found the offending commit
(thanks!)

[Adrian Perez]

Created attachment 451046 [details]
Patch

[Alejandro G. Castro]

Comment on attachment 451046 [details]
Patch

Looks good! Thanks for fixing this! Compilation issues do not seem related?

[Adrian Perez]

Created attachment 451075 [details]
Patch v2

[Adrian Perez]

(In reply to Alejandro G. Castro from comment #3)
> Comment on attachment 451046 [details]
> Patch
> 
> Looks good! Thanks for fixing this! Compilation issues do not seem related?

One of them (from the i386 32-bit builder) was actually related, I have
uploaded a second version of the patch which avoids using list(POP_BACK)
which is not available in older CMake versions. I am currently chatting
with Angelos to try and understand the other failure to make sure it's
either unrelated or this patch changed to avoid it if needed.

[EWS]

Committed r289218 (246903@main): <https://commits.webkit.org/246903@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451075 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88570928>