Bug 236192

Summary: RenderLayer: Simplify RenderElement::paint() calls
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: Layout and RenderingAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, rbuis, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236186    
Bug Blocks: 90738, 236194    
Attachments:
Description Flags
Patch, v1
none
Patch, v2 simon.fraser: review+

Description Nikolas Zimmermann 2022-02-05 16:28:29 PST
RenderLayer: Simplify RenderElement::paint() calls.

Introduce "paintOffsetForRenderer(fragment, localPaintingInfo)" inline helper returning:
    
    toLayoutPoint(fragment.layerBounds.location() - rendererLocation() + localPaintingInfo.subpixelOffset)
    
Avoid repeating this formula in various places in RenderLayer - unify it.
Comment 1 Nikolas Zimmermann 2022-02-06 03:12:07 PST
Created attachment 451033 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-02-06 03:12:24 PST
Will submit to EWS, once 236186 landed.
Comment 3 Nikolas Zimmermann 2022-02-06 04:42:39 PST
The failed builds are expected, the patch went to EWS too early...
Comment 4 Nikolas Zimmermann 2022-02-07 05:58:13 PST
Created attachment 451084 [details]
Patch, v2
Comment 5 Nikolas Zimmermann 2022-02-08 01:49:15 PST
Thanks Simon for checking!
Comment 6 Nikolas Zimmermann 2022-02-08 01:53:20 PST
Committed r289360 (246948@trunk): <https://commits.webkit.org/246948@trunk>
Comment 7 Radar WebKit Bug Importer 2022-02-08 01:54:17 PST
<rdar://problem/88618973>