| Summary: | [LBSE] Extend overflow/clip rect handling for SVG layers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 90738, 236194 | ||||||
| Attachments: |
|
||||||
|
Description
Nikolas Zimmermann
2022-02-05 16:24:45 PST
Created attachment 451013 [details]
Patch, v1
Comment on attachment 451013 [details]
Patch, v1
This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not enabled, but since we want to convert to it given all the benefits I think it is no problem.
(In reply to Rob Buis from comment #2) > Comment on attachment 451013 [details] > Patch, v1 > > This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not > enabled, but since we want to convert to it given all the benefits I think > it is no problem. I also thought about caching the 'is<RenderBox>(renderer())' somewhere, but this smells like a pre-mature optimization that looks cheaper on first sight, but without instruction level profiling I wouldn't be on it. Committed r289204 (246890@trunk): <https://commits.webkit.org/246890@trunk> |