Bug 236188

Summary: [LBSE] Extend overflow/clip rect handling for SVG layers
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90738, 236194    
Attachments:
Description Flags
Patch, v1 rbuis: review+

Nikolas Zimmermann
Reported 2022-02-05 16:24:45 PST
Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support: Allow to re-use overflow clipping logic for certain type of SVG containers, deriving from RenderSVGModelObject, namely: RenderSVGViewportContainer / RenderSVGResourceMarker (RenderSVGRoot uses the same logic, but through RenderReplaced: it doesn't derived from RenderSVGModelObject). Once all things are in place, the SVG overflow logic is gone, replaced in all areas by the shared CSS one.
Attachments
Patch, v1 (7.08 KB, patch)
2022-02-05 16:43 PST, Nikolas Zimmermann 		rbuis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2022-02-05 16:43:52 PST
Created attachment 451013 [details] Patch, v1
Rob Buis
Comment 2 2022-02-07 02:09:39 PST
Comment on attachment 451013 [details] Patch, v1 This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not enabled, but since we want to convert to it given all the benefits I think it is no problem.
Nikolas Zimmermann
Comment 3 2022-02-07 03:33:42 PST
(In reply to Rob Buis from comment #2) > Comment on attachment 451013 [details] > Patch, v1 > > This could be more efficient in the case LAYER_BASED_SVG_ENGINE is not > enabled, but since we want to convert to it given all the benefits I think > it is no problem. I also thought about caching the 'is<RenderBox>(renderer())' somewhere, but this smells like a pre-mature optimization that looks cheaper on first sight, but without instruction level profiling I wouldn't be on it.
Nikolas Zimmermann
Comment 4 2022-02-07 03:36:50 PST
Committed r289204 (246890@trunk): <https://commits.webkit.org/246890@trunk>
Radar WebKit Bug Importer
Comment 5 2022-02-07 03:37:20 PST
<rdar://problem/88564886>
Note You need to log in before you can comment on or make changes to this bug.