Bug 236170

Summary: Tidy up some ImageBuffer-related classes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
darin: review+
Patch none

Simon Fraser (smfr)
Reported 2022-02-04 20:49:30 PST
Tidy up some ImageBuffer-related classes
Attachments
Patch (15.40 KB, patch)
2022-02-04 20:51 PST, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (18.85 KB, patch)
2022-02-04 21:57 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (19.73 KB, patch)
2022-02-05 11:08 PST, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Patch (22.12 KB, patch)
2022-02-07 12:08 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2022-02-04 20:51:10 PST
Created attachment 450970 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-02-04 21:57:22 PST
Created attachment 450973 [details] Patch
Simon Fraser (smfr)
Comment 3 2022-02-05 11:08:01 PST
Created attachment 450991 [details] Patch
Darin Adler
Comment 4 2022-02-06 15:21:32 PST
Comment on attachment 450991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450991&action=review > Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h:49 > + GraphicsContext& context() const final; Could consider also making these private if they are always called polymorphically, on the ImageBufferCGBackend base class.
Simon Fraser (smfr)
Comment 5 2022-02-07 12:08:16 PST
Created attachment 451135 [details] Patch
Simon Fraser (smfr)
Comment 6 2022-02-07 14:28:10 PST
https://trac.webkit.org/changeset/289240/webkit
Radar WebKit Bug Importer
Comment 7 2022-02-07 14:29:43 PST
<rdar://problem/88594557>
Note You need to log in before you can comment on or make changes to this bug.