Bug 236166

Summary: AX: Move node-dependent role computation to AccessibilityNodeObject from AccessibilityRenderObject
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2022-02-04 16:27:55 PST
This will make AX objects that typically have renderers but sometimes don't (e.g. objects with `hidden` + `aria-hidden="false"`, eventually objects with `display: contents`) more accessible.
Attachments
Patch (45.21 KB, patch)
2022-02-04 16:38 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (63.71 KB, patch)
2022-02-05 08:54 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (63.70 KB, patch)
2022-02-07 10:47 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-04 16:28:11 PST
<rdar://problem/88513740>
Tyler Wilcock
Comment 2 2022-02-04 16:38:01 PST
Created attachment 450948 [details] Patch
Tyler Wilcock
Comment 3 2022-02-05 08:54:58 PST
Created attachment 450988 [details] Patch
chris fleizach
Comment 4 2022-02-07 09:21:36 PST
Comment on attachment 450988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450988&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:256 > + HTMLSelectElement& selectElement = downcast<HTMLSelectElement>(*node()); can probably use auto& here
Tyler Wilcock
Comment 5 2022-02-07 10:47:59 PST
Created attachment 451124 [details] Patch
EWS
Comment 6 2022-02-07 16:23:33 PST
Committed r289248 (246932@main): <https://commits.webkit.org/246932@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451124 [details].
Note You need to log in before you can comment on or make changes to this bug.