Bug 236164

Summary: [libpas] allocation failure crash should be PAS_NEVER_INLINE
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch saam: review+

Description Yusuke Suzuki 2022-02-04 15:55:12 PST 
[libpas] allocation failure crash should be NEVER_INLINED
Comment 1 Yusuke Suzuki 2022-02-04 15:56:23 PST 
Created attachment 450946 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-04 15:57:18 PST 
Comment on attachment 450946 [details]
Patch

Oops, I'll a bit fix it.
Comment 3 Yusuke Suzuki 2022-02-04 16:17:24 PST 
Created attachment 450947 [details]
Patch
Comment 4 Saam Barati 2022-02-04 16:19:59 PST 
Comment on attachment 450947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review

> Source/bmalloc/libpas/src/libpas/pas_utils.c:60
> +    pas_panic("allocation did fail because of out-of-memory\n");

do we want to make sure this call gets inlined?
Comment 5 Yusuke Suzuki 2022-02-04 16:21:53 PST 
Comment on attachment 450947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review

>> Source/bmalloc/libpas/src/libpas/pas_utils.c:60
>> +    pas_panic("allocation did fail because of out-of-memory\n");
> 
> do we want to make sure this call gets inlined?

Discussed with Saam. I'll change it to __builtin_trap to make pas_panic_on_out_of_memory_error top signature.
Comment 6 Yusuke Suzuki 2022-02-04 16:50:17 PST 
OK we ensured it is built, landing.
Comment 7 Yusuke Suzuki 2022-02-04 16:51:59 PST 
Committed r289144 (246840@trunk): <https://commits.webkit.org/246840@trunk>
Comment 8 Radar WebKit Bug Importer 2022-02-04 16:52:16 PST 
<rdar://problem/88514835>