| Summary: | [WebAuthn] Use AuthenticationServicesAgent for WebAuthn calls on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | pascoe <pascoe> | ||||||
| Component: | WebKit Misc. | Assignee: | pascoe <pascoe> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, ews-watchlist, jiewen_tan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
pascoe@apple.com
2022-02-04 12:33:30 PST
Created attachment 450930 [details]
Patch
Comment on attachment 450930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450930&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:313 > + [proxy.get() performAuthorizationRequestsForContext:requestContext.get() withCompletionHandler:makeBlockPtr([handler = WTFMove(handler), proxy = WTFMove(proxy)](id <ASCCredentialProtocol> credential, NSError *error) mutable { Nit: I don't think you need to 'get()' on proxy when calling a method like this (though you *do* need to call 'get()' when you want to pass a pointer. Created attachment 451300 [details]
Patch for landing
Committed r289436 (246989@main): <https://commits.webkit.org/246989@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451300 [details]. |