RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface

• Component: WebRTC
• Status: RESOLVED FIXED

[youenn fablet]

RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface

[youenn fablet]

Created attachment 450892 [details]
Patch

[Eric Carlson]

Comment on attachment 450892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450892&action=review

> Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:102
> +        auto bufferPool = m_shouldUseIOSurface ? createIOSurfaceCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes) : createInMemoryCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes);

Nit: this is long enough that I think it would be easier to read and understand as an `if ... else`

[youenn fablet]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 450892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450892&action=review
> 
> > Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:102
> > +        auto bufferPool = m_shouldUseIOSurface ? createIOSurfaceCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes) : createInMemoryCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes);
> 
> Nit: this is long enough that I think it would be easier to read and
> understand as an `if ... else`

OK, let's introduce createCVPixelBufferPool with an option shouldUseIOSurface parameter then.

[youenn fablet]

Created attachment 451230 [details]
Patch for landing

[EWS]

Committed r289365 (246953@main): <https://commits.webkit.org/246953@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451230 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88623072>