Bug 236139

Summary: RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2022-02-04 06:55:55 PST
RealtimeOutgoingVideoSourceCocoa rotation session should not use IOSurface
Attachments
Patch (11.32 KB, patch)
2022-02-04 06:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.98 KB, patch)
2022-02-08 03:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-02-04 06:58:06 PST
Created attachment 450892 [details] Patch
Eric Carlson
Comment 2 2022-02-04 09:22:01 PST
Comment on attachment 450892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450892&action=review > Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:102 > + auto bufferPool = m_shouldUseIOSurface ? createIOSurfaceCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes) : createInMemoryCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes); Nit: this is long enough that I think it would be easier to read and understand as an `if ... else`
youenn fablet
Comment 3 2022-02-08 03:05:11 PST
(In reply to Eric Carlson from comment #2) > Comment on attachment 450892 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450892&action=review > > > Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:102 > > + auto bufferPool = m_shouldUseIOSurface ? createIOSurfaceCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes) : createInMemoryCVPixelBufferPool(m_rotatedSize.width(), m_rotatedSize.height(), m_pixelFormat, 0u, m_isCGImageCompatible == IsCGImageCompatible::Yes); > > Nit: this is long enough that I think it would be easier to read and > understand as an `if ... else` OK, let's introduce createCVPixelBufferPool with an option shouldUseIOSurface parameter then.
youenn fablet
Comment 4 2022-02-08 03:07:53 PST
Created attachment 451230 [details] Patch for landing
EWS
Comment 5 2022-02-08 04:27:52 PST
Committed r289365 (246953@main): <https://commits.webkit.org/246953@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451230 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-08 04:28:20 PST
<rdar://problem/88623072>
Note You need to log in before you can comment on or make changes to this bug.