| Summary: | LibWebRTCCodecs SharedVideoFrameWriters can deadlock in case of GPUProcess crash | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2022-02-04 02:14:36 PST
Created attachment 450883 [details]
Patch
Comment on attachment 450883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450883&action=review > Source/WebKit/ChangeLog:10 > + To prevent this, whenever we detect a GPUProcess connection, we disable SharedVideoFrameWriters, which has the effect of Do you mean whenever we detect a GPUProcess *crash*? > Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:45 > + fprintf(stderr, "SharedVideoFrameWriter::wait\n"); Oops! > LayoutTests/webrtc/vp8-then-h264-gpu-process-crash.html:91 > +}, "Frames should be coming event after gpu process crash"); a/event/even/ Created attachment 451231 [details]
Patch for landing
Created attachment 451232 [details]
Patch for landing
Patch 451231 does not build Created attachment 451236 [details]
Patch for landing
Committed r289381 (246969@main): <https://commits.webkit.org/246969@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451236 [details]. |