Bug 236131

Summary: Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ews-watchlist, glenn, hta, jer.noble, kkinnunen, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2022-02-04 02:01:14 PST
Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
Attachments
Patch (64.33 KB, patch)
2022-02-04 02:05 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (45.30 KB, patch)
2022-02-22 06:19 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (56.90 KB, patch)
2022-02-23 08:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (56.93 KB, patch)
2022-02-23 10:16 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (44.67 KB, patch)
2022-02-28 01:03 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (43.26 KB, patch)
2022-03-03 04:39 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-02-04 02:05:40 PST
Created attachment 450881 [details] Patch
youenn fablet
Comment 2 2022-02-04 02:06:22 PST
(In reply to youenn fablet from comment #1) > Created attachment 450881 [details] > Patch Not yet ready for review. Need to sync it with https://bugs.webkit.org/show_bug.cgi?id=236099
Radar WebKit Bug Importer
Comment 3 2022-02-11 02:02:16 PST
<rdar://problem/88805580>
youenn fablet
Comment 4 2022-02-22 06:19:12 PST
Created attachment 452864 [details] Patch
youenn fablet
Comment 5 2022-02-23 08:07:42 PST
Created attachment 452982 [details] Patch
youenn fablet
Comment 6 2022-02-23 10:16:30 PST
Created attachment 452998 [details] Patch
youenn fablet
Comment 7 2022-02-28 01:03:05 PST
Created attachment 453374 [details] Patch
youenn fablet
Comment 8 2022-03-03 04:39:46 PST
Created attachment 453720 [details] Patch
Eric Carlson
Comment 9 2022-03-08 08:27:27 PST
Comment on attachment 453720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453720&action=review > Source/WebCore/ChangeLog:14 > + In case we send VideoFrameLibWebRTC through RealtimeOutgoingVideoSourceCocoa, directly send the video frame buffer. > + When receiving libwebrtc video frame buffers in RealtimeIncomingVideoSourceCocoa, make use of VideoFrameLibWebRTC to delay conversion of the video frame buffer in a CVPixelBufferRef. > + In most cases, the conversion is unneeded as the video frame buffer will be used for rendering and will be copied to shared memory through SharedVideoFrameWriter. > + Fix bugs in handling of YUV conversion libwebrtc routines. > + Minor refactoring to have a default asVideoFrameCV method implementatin in VideoFrame. Nit: these lines are really long
EWS
Comment 10 2022-03-09 09:49:10 PST
Committed r291051 (248225@main): <https://commits.webkit.org/248225@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453720 [details].
Alex Christensen
Comment 11 2022-03-09 14:32:05 PST
r291076
Alex Christensen
Comment 12 2022-03-09 14:38:37 PST
r291078
Note You need to log in before you can comment on or make changes to this bug.