Bug 236131

Summary: Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ews-watchlist, glenn, hta, jer.noble, kkinnunen, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description youenn fablet 2022-02-04 02:01:14 PST 
Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
Comment 1 youenn fablet 2022-02-04 02:05:40 PST 
Created attachment 450881 [details]
Patch
Comment 2 youenn fablet 2022-02-04 02:06:22 PST 
(In reply to youenn fablet from comment #1)
> Created attachment 450881 [details]
> Patch

Not yet ready for review.
Need to sync it with https://bugs.webkit.org/show_bug.cgi?id=236099
Comment 3 Radar WebKit Bug Importer 2022-02-11 02:02:16 PST 
<rdar://problem/88805580>
Comment 4 youenn fablet 2022-02-22 06:19:12 PST 
Created attachment 452864 [details]
Patch
Comment 5 youenn fablet 2022-02-23 08:07:42 PST 
Created attachment 452982 [details]
Patch
Comment 6 youenn fablet 2022-02-23 10:16:30 PST 
Created attachment 452998 [details]
Patch
Comment 7 youenn fablet 2022-02-28 01:03:05 PST 
Created attachment 453374 [details]
Patch
Comment 8 youenn fablet 2022-03-03 04:39:46 PST 
Created attachment 453720 [details]
Patch
Comment 9 Eric Carlson 2022-03-08 08:27:27 PST 
Comment on attachment 453720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453720&action=review

> Source/WebCore/ChangeLog:14
> +        In case we send VideoFrameLibWebRTC through RealtimeOutgoingVideoSourceCocoa, directly send the video frame buffer.
> +        When receiving libwebrtc video frame buffers in RealtimeIncomingVideoSourceCocoa, make use of VideoFrameLibWebRTC to delay conversion of the video frame buffer in a CVPixelBufferRef.
> +        In most cases, the conversion is unneeded as the video frame buffer will be used for rendering and will be copied to shared memory through SharedVideoFrameWriter.
> +        Fix bugs in handling of YUV conversion libwebrtc routines.
> +        Minor refactoring to have a default asVideoFrameCV method implementatin in VideoFrame.

Nit: these lines are really long
Comment 10 EWS 2022-03-09 09:49:10 PST 
Committed r291051 (248225@main): <https://commits.webkit.org/248225@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453720 [details].
Comment 11 Alex Christensen 2022-03-09 14:32:05 PST 
r291076
Comment 12 Alex Christensen 2022-03-09 14:38:37 PST 
r291078