Bug 236105

Summary: WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, emw, eric.carlson, ews-watchlist, kbr, keith_miller, kondapallykalyan, mark.lam, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Michael Saboff
Reported 2022-02-03 14:28:18 PST
When creating a framework dylib, we pass the -install_name option when linking with the argument of where the library will normally be found. During builds this argument is in the value LD_DYLIB_INSTALL_NAME, which is computed from DYLIB_INSTALL_NAME_BASE and EXECUTABLE_PATH. For Catalyst builds using a system content path, that system content path is getting incorrectly prepended to DYLIB_INSTALL_NAME_BASE and needs to be removed.
Attachments
Patch (21.58 KB, patch)
2022-02-03 16:48 PST, Michael Saboff 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-02-03 14:28:34 PST
<rdar://88387438>
Michael Saboff
Comment 2 2022-02-03 16:48:55 PST
Created attachment 450836 [details] Patch
EWS Watchlist
Comment 3 2022-02-03 16:51:27 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Michael Saboff
Comment 4 2022-02-03 17:16:10 PST
Committed r289091 (?): <https://commits.webkit.org/r289091>
Note You need to log in before you can comment on or make changes to this bug.