Bug 236105

Summary:

WebKit projects have incorrect install name for the frameworks for Catalyst builds with the system content path

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

Platform

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dino, emw, eric.carlson, ews-watchlist, kbr, keith_miller, kondapallykalyan, mark.lam, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	saam: review+

Description Michael Saboff 2022-02-03 14:28:18 PST

When creating a framework dylib, we pass the -install_name option when linking with the argument of where the library will normally be found.  During builds this argument is in the value LD_DYLIB_INSTALL_NAME, which is computed from DYLIB_INSTALL_NAME_BASE and EXECUTABLE_PATH.  For Catalyst builds using a system content path, that system content path is getting incorrectly prepended to DYLIB_INSTALL_NAME_BASE and needs to be removed.

Comment 1 Michael Saboff 2022-02-03 14:28:34 PST

<rdar://88387438>

Comment 2 Michael Saboff 2022-02-03 16:48:55 PST

Created attachment 450836 [details]
Patch

Comment 3 EWS Watchlist 2022-02-03 16:51:27 PST

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Comment 4 Michael Saboff 2022-02-03 17:16:10 PST

Committed r289091 (?): <https://commits.webkit.org/r289091>