Bug 236101

Summary: Fix WPT test importer and resync web-platform-tests/workers from upstream
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, darin, ews-watchlist, ggaren, glenn, gsnedders, jbedard, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235958    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2022-02-03 13:36:14 PST 
Fix WPT test importer and resync web-platform-tests/workers from upstream.
Comment 1 Chris Dumez 2022-02-03 13:41:18 PST 
Created attachment 450811 [details]
Patch
Comment 2 Chris Dumez 2022-02-03 13:47:22 PST 
Created attachment 450814 [details]
Patch
Comment 3 Chris Dumez 2022-02-03 14:07:55 PST 
Created attachment 450818 [details]
Patch
Comment 4 Chris Dumez 2022-02-03 14:16:17 PST 
Created attachment 450820 [details]
Patch
Comment 5 Chris Dumez 2022-02-03 14:32:17 PST 
Created attachment 450823 [details]
Patch
Comment 6 Chris Dumez 2022-02-03 14:39:52 PST 
Created attachment 450824 [details]
Patch
Comment 7 youenn fablet 2022-02-04 07:31:35 PST 
Comment on attachment 450824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450824&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:194
> +            window=('html',),

s/html',/html'/ here and below.
Comment 8 Chris Dumez 2022-02-04 07:35:46 PST 
Created attachment 450895 [details]
Patch
Comment 9 Chris Dumez 2022-02-04 07:49:43 PST 
Created attachment 450897 [details]
Patch
Comment 10 Chris Dumez 2022-02-04 07:51:17 PST 
(In reply to youenn fablet from comment #7)
> Comment on attachment 450824 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450824&action=review
> 
> > Tools/Scripts/webkitpy/w3c/test_importer.py:194
> > +            window=('html',),
> 
> s/html',/html'/ here and below.

Turns out this is required in Python to make sure it gets recognized as a tuple.
I tried but it caused webkitpy tests to fail so I went back to my original code.
Comment 11 Chris Dumez 2022-02-04 08:36:01 PST 
Comment on attachment 450897 [details]
Patch

Clearing flags on attachment: 450897

Committed r289116 (246813@trunk): <https://commits.webkit.org/246813@trunk>
Comment 12 Chris Dumez 2022-02-04 08:36:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2022-02-04 08:37:20 PST 
<rdar://problem/88490743>