| Summary: | Add a helper method on VideoFullscreenManagerProxy to request video frame data | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, darin, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 236090 | ||||||||
| Bug Blocks: | 236100 | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2022-02-03 11:05:12 PST
Created attachment 450800 [details]
Depends on #236090
Comment on attachment 450800 [details] Depends on #236090 View in context: https://bugs.webkit.org/attachment.cgi?id=450800&action=review > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533 > + auto* gpuProcess = GPUProcessProxy::singletonIfCreated(); > + if (!gpuProcess) { > + completionHandler({ }); > + return; > + } Nit: you might want to do this first because there's no need to find the interface of player unless the GPUP is running. (In reply to Eric Carlson from comment #2) > Comment on attachment 450800 [details] > Depends on #236090 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450800&action=review > > > Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:533 > > + auto* gpuProcess = GPUProcessProxy::singletonIfCreated(); > > + if (!gpuProcess) { > > + completionHandler({ }); > > + return; > > + } > > Nit: you might want to do this first because there's no need to find the > interface of player unless the GPUP is running. Good point! Moved this check/early return to the top. Created attachment 450838 [details]
Depends on #236090
Comment on attachment 450838 [details]
Depends on #236090
Thanks for the review!
Committed r289221 (246906@main): <https://commits.webkit.org/246906@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450838 [details]. |