Bug 236091

Summary:

Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

235647, 235820, 235924

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
[Image] With patch applied	none

Description Nikita Vasilyev 2022-02-03 10:35:23 PST

Add an Engineering setting, not Experimental since the feature isn't yet usable for STP users.

<rdar://problem/87888387>

Comment 1 Radar WebKit Bug Importer 2022-02-03 10:35:38 PST

<rdar://problem/88443529>

Comment 2 Nikita Vasilyev 2022-02-03 10:41:17 PST

Created attachment 450792 [details]
Patch

Comment 3 Nikita Vasilyev 2022-02-03 10:42:44 PST

Created attachment 450794 [details]
[Image] With patch applied

Comment 4 Patrick Angle 2022-02-03 10:54:42 PST

Comment on attachment 450792 [details]
Patch

r=me, but please open another bugzilla bug blocked on this one to remove the setting particularly since we typically wouldn't add a new setting that isn't being used by the patch it was added in. Please also mark this as a blocker for both your patch and Razvan's patch that will rely on this setting in the coming days.

Comment 5 EWS 2022-02-03 11:47:52 PST

Committed r289064 (246771@main): <https://commits.webkit.org/246771@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450792 [details].