Bug 236091

Summary: Web Inspector: [Flexbox] Add setting to guard Flexbox Inspector feature
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 235647, 235820, 235924    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
[Image] With patch applied none

Nikita Vasilyev
Reported 2022-02-03 10:35:23 PST
Add an Engineering setting, not Experimental since the feature isn't yet usable for STP users. <rdar://problem/87888387>
Attachments
Patch (2.59 KB, patch)
2022-02-03 10:41 PST, Nikita Vasilyev 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[Image] With patch applied (31.64 KB, image/png)
2022-02-03 10:42 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-03 10:35:38 PST
<rdar://problem/88443529>
Nikita Vasilyev
Comment 2 2022-02-03 10:41:17 PST
Created attachment 450792 [details] Patch
Nikita Vasilyev
Comment 3 2022-02-03 10:42:44 PST
Created attachment 450794 [details] [Image] With patch applied
Patrick Angle
Comment 4 2022-02-03 10:54:42 PST
Comment on attachment 450792 [details] Patch r=me, but please open another bugzilla bug blocked on this one to remove the setting particularly since we typically wouldn't add a new setting that isn't being used by the patch it was added in. Please also mark this as a blocker for both your patch and Razvan's patch that will rely on this setting in the coming days.
EWS
Comment 5 2022-02-03 11:47:52 PST
Committed r289064 (246771@main): <https://commits.webkit.org/246771@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450792 [details].
Note You need to log in before you can comment on or make changes to this bug.