Summary: | Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, eric.carlson, ews-watchlist, glenn, jer.noble, megan_gardner, philipj, sergio, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 236094 | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2022-02-03 09:48:16 PST
Created attachment 450795 [details]
For EWS
Comment on attachment 450795 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=450795&action=review Thanks for the review! > Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:320 > + setPlayerIdentifier(contextId, player->identifier()); Ah, so after a bit more testing, I discovered is that this breaks fullscreen media in WebKit2 in the case where the GPUP: Media flag is off, since it tries to send an invalid (0) ObjectIdentifier across the process boundary :P I'll add a check for here to guard against this case. Created attachment 450837 [details]
For landing
Committed r289100 (246797@main): <https://commits.webkit.org/246797@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450837 [details]. |