Bug 236090

Summary: Teach VideoFullscreenInterface to keep track of its corresponding MediaPlayer's MediaPlayerIdentifier
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric.carlson, ews-watchlist, glenn, jer.noble, megan_gardner, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236094    
Attachments:
Description Flags
For EWS
eric.carlson: review+
For landing none

Wenson Hsieh
Reported 2022-02-03 09:48:16 PST
.
Attachments
For EWS (18.60 KB, patch)
2022-02-03 10:43 PST, Wenson Hsieh 		eric.carlson: review+
DetailsFormatted DiffDiff
For landing (18.65 KB, patch)
2022-02-03 16:55 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-02-03 10:43:53 PST
Created attachment 450795 [details] For EWS
Wenson Hsieh
Comment 2 2022-02-03 16:21:10 PST
Comment on attachment 450795 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=450795&action=review Thanks for the review! > Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:320 > + setPlayerIdentifier(contextId, player->identifier()); Ah, so after a bit more testing, I discovered is that this breaks fullscreen media in WebKit2 in the case where the GPUP: Media flag is off, since it tries to send an invalid (0) ObjectIdentifier across the process boundary :P I'll add a check for here to guard against this case.
Wenson Hsieh
Comment 3 2022-02-03 16:55:09 PST
Created attachment 450837 [details] For landing
EWS
Comment 4 2022-02-03 18:46:59 PST
Committed r289100 (246797@main): <https://commits.webkit.org/246797@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450837 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-03 18:48:17 PST
<rdar://problem/88468414>
Note You need to log in before you can comment on or make changes to this bug.