Bug 236083

Summary: Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: MediaAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric.carlson, ews-watchlist, glenn, jer.noble, megan_gardner, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236100    
Attachments:
Description Flags
For EWS
none
Rebase on trunk
ews-feeder: commit-queue-
Fix tvOS build
none
Fix Win/GTK/WPE builds
eric.carlson: review+
Patch for landing none

Description Wenson Hsieh 2022-02-03 08:34:36 PST
.
Comment 1 Wenson Hsieh 2022-02-03 08:58:37 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2022-02-03 09:41:50 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2022-02-03 10:41:55 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2022-02-03 13:42:46 PST
Created attachment 450813 [details]
Fix Win/GTK/WPE builds
Comment 5 Eric Carlson 2022-02-03 14:58:08 PST
Comment on attachment 450813 [details]
Fix Win/GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=450813&action=review

> Source/WebKit/ChangeLog:9
> +        PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been

s/this/these/
Comment 6 Wenson Hsieh 2022-02-03 16:10:32 PST
Comment on attachment 450813 [details]
Fix Win/GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=450813&action=review

Thanks for the review!

>> Source/WebKit/ChangeLog:9
>> +        PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been
> 
> s/this/these/

Fixed the typo.
Comment 7 Wenson Hsieh 2022-02-03 16:18:43 PST
Created attachment 450835 [details]
Patch for landing
Comment 8 EWS 2022-02-03 17:08:05 PST
Committed r289090 (246790@main): <https://commits.webkit.org/246790@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450835 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-03 17:09:18 PST
<rdar://problem/88464056>