[XCBuild] Users of libgtest.a depend on headers from gtest.framework

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Elliott Williams]

In Make-based sequential builds, we always build gtest's dynamic target (gtest.framework). This target also builds the static library (libgtest.a) as a dependency, but only copies headers to the framework (i.e. `$SRCROOT/gtest/include` is copied to `$BUILT_PRODUCT_DIR/gtest.framework/Headers`). 

When a downstream project imports a gtest header, it finds it in the framework bundle.

The problem is that WebKit never actually links against gtest.framework. All our targets which use gtest link against the static library (libgtest.a). In workspace builds, Xcode sees this and only builds gtest's static target. Our surprise dependency on the _headers_ of gtest.framework is revealed as users of gtest fail to find its headers.

Fix by making gtest's static target also produce headers.

[Radar WebKit Bug Importer]

<rdar://problem/88406549>

[Elliott Williams]

Created attachment 450713 [details]
Add headers phase in gtest static target

[EWS]

Committed r289027 (246735@main): <https://commits.webkit.org/246735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450713 [details].