Bug 236041

Summary: Improve color contrast of dark mode syntax highlighting
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: jond, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Before patch is applied
none
After patch applied
none
Patch none

Jon Davis
Reported 2022-02-02 14:46:07 PST
The code block syntax highlighting in dark mode needs better contrast.
Attachments
Patch (3.70 KB, patch)
2022-02-02 15:08 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Before patch is applied (52.70 KB, image/png)
2022-02-02 15:09 PST, Jon Davis 		no flags
Details
After patch applied (56.03 KB, image/png)
2022-02-02 15:10 PST, Jon Davis 		no flags
Details
Patch (3.35 KB, patch)
2022-02-02 15:41 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2022-02-02 15:08:34 PST
Created attachment 450701 [details] Patch
Jon Davis
Comment 2 2022-02-02 15:09:36 PST
Created attachment 450702 [details] Before patch is applied
Jon Davis
Comment 3 2022-02-02 15:10:00 PST
Created attachment 450703 [details] After patch applied
Simon Fraser (smfr)
Comment 4 2022-02-02 15:17:10 PST
Comment on attachment 450701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450701&action=review > Websites/webkit.org/ChangeLog:20 > +2022-02-02 Jon Davis <jond@apple.com> > + > + Improve color contrast of dark mode syntax highlighting. > + https://bugs.webkit.org/show_bug.cgi?id=236041 > + > + Reviewed by NOBODY (OOPS!). > + > + * wp-content/themes/webkit/style.css: > + (@media(prefers-color-scheme:dark) :root): Double changelog.
Myles C. Maxfield
Comment 5 2022-02-02 15:17:25 PST
Comment on attachment 450701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450701&action=review > Websites/webkit.org/ChangeLog:20 > +2022-02-02 Jon Davis <jond@apple.com> > + > + Improve color contrast of dark mode syntax highlighting > + https://bugs.webkit.org/show_bug.cgi?id=236041 > + > + Reviewed by NOBODY (OOPS!). > + > + * wp-content/themes/webkit/search.php: Added. > + * wp-content/themes/webkit/style.css: > + (@media(prefers-color-scheme:dark) :root): > + > +2022-02-02 Jon Davis <jond@apple.com> > + > + Improve color contrast of dark mode syntax highlighting. > + https://bugs.webkit.org/show_bug.cgi?id=236041 > + > + Reviewed by NOBODY (OOPS!). > + > + * wp-content/themes/webkit/style.css: > + (@media(prefers-color-scheme:dark) :root): Ideally this wouldn't be duplicated.
Jon Davis
Comment 6 2022-02-02 15:41:34 PST
Created attachment 450707 [details] Patch
EWS
Comment 7 2022-02-02 16:32:04 PST
Committed r289013 (246722@main): <https://commits.webkit.org/246722@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450707 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-02 16:33:18 PST
<rdar://problem/88408169>
Note You need to log in before you can comment on or make changes to this bug.