Bug 235993

Summary: Delete SelectionAcrossShadowBoundariesEnabled
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, japhet, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Ryosuke Niwa 2022-02-01 17:50:55 PST 
This runtime flag is always on.
Comment 1 Ryosuke Niwa 2022-02-01 17:54:04 PST 
Created attachment 450598 [details]
Patch
Comment 2 Darin Adler 2022-02-03 03:58:14 PST 
Comment on attachment 450598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450598&action=review

> Source/WebCore/editing/gtk/EditorGtk.cpp:120
> +    pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No);

Editing mistake here. Left behind “: SerializedComposedTree::No”.

> Source/WebCore/editing/libwpe/EditorLibWPE.cpp:68
> +    pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No);

Ditto.
Comment 3 Ryosuke Niwa 2022-02-03 15:52:35 PST 
Created attachment 450832 [details]
Patch
Comment 4 Darin Adler 2022-02-03 16:37:33 PST 
Comment on attachment 450832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450832&action=review

> Source/WebCore/editing/Editor.cpp:3313
> +    return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree);

Should use commas here instead:

    return selectedText({ TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree });
Comment 5 Ryosuke Niwa 2022-02-03 21:47:25 PST 
(In reply to Darin Adler from comment #4)
> Comment on attachment 450832 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450832&action=review
> 
> > Source/WebCore/editing/Editor.cpp:3313
> > +    return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree);
> 
> Should use commas here instead:
> 
>     return selectedText({ TextIteratorBehavior::EmitsImageAltText,
> TextIteratorBehavior::TraversesFlatTree });

Sure, will fix.
Comment 6 Ryosuke Niwa 2022-02-03 21:48:12 PST 
Created attachment 450865 [details]
Patch for landing
Comment 7 EWS 2022-02-03 22:38:26 PST 
Committed r289104 (246801@main): <https://commits.webkit.org/246801@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450865 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-03 22:39:25 PST 
<rdar://problem/88474922>
Comment 9 Darin Adler 2022-02-04 08:15:21 PST 
Comment on attachment 450865 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=450865&action=review

> Source/WebCore/editing/Editor.cpp:3313
> +    return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree });

Maybe we can omit OptionSet here? I guess not because you would have tried that?
Comment 10 Ryosuke Niwa 2022-02-04 11:34:55 PST 
(In reply to Darin Adler from comment #9)
> Comment on attachment 450865 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450865&action=review
> 
> > Source/WebCore/editing/Editor.cpp:3313
> > +    return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree });
> 
> Maybe we can omit OptionSet here? I guess not because you would have tried
> that?

No, it didn't work.