Summary: | wml/WMLTableElement.cpp has non-ASCII characters in comment and can't be compiled on CJK Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jungshik Shin <jshin> | ||||
Component: | WebCore Misc. | Assignee: | Jungshik Shin <jshin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Trivial | CC: | ap, darin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Jungshik Shin
2009-01-28 12:58:03 PST
Created attachment 27119 [details]
patch
Applying this patch is a step forward, but there are other header files (in Quicktime SDK and in WebKitLibraries/win/include) with the same issue leading to a compilation error on CJK Windows. For Quicktime SDK, I filed a bug report at bugreport.apple.com a while ago.
Other files in WebKitLibraries/win/include with the issue are CMTypes.h and CMApplication.h Perhaps, we have to add a note to the Windows build page about the issue (do not set the Windows system code page to one of CJK codepages to build webkit on Windows) until all of them are cleaned up. Comment on attachment 27119 [details]
patch
r=me
|