Bug 235978

Summary:

Flaky scope.assertNoException() assertion in ~JSExecState when running workers WPT tests

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, hi, mark.lam, mkwst, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

235958

Attachments:

Description	Flags
Patch	mark.lam: review+, ews-feeder: commit-queue-
WIP Patch	none
proposed patch.	ews-feeder: commit-queue-
proposed patch.	none

Description Chris Dumez 2022-02-01 14:54:50 PST

Flaky scope.assertNoException() assertion in ~JSExecState when running workers WPT tests:
Thread 8 Crashed:: WebCore: SharedWorker
0   JavaScriptCore                	       0x27fca827e WTFCrash + 14
1   WebCore                       	       0x293d64baa JSC::ExceptionScope::assertNoException() + 122 (ExceptionScope.h:55)
2   WebCore                       	       0x296198305 WebCore::JSExecState::~JSExecState() + 325 (JSExecState.h:149)
3   WebCore                       	       0x2961980e5 WebCore::JSExecState::~JSExecState() + 21 (JSExecState.h:133)
4   WebCore                       	       0x296230857 WebCore::JSExecState::loadModule(JSC::JSGlobalObject&, JSC::SourceCode const&, JSC::JSValue) + 71 (JSExecState.h:105)
5   WebCore                       	       0x2986d80fa WebCore::WorkerOrWorkletScriptController::loadModuleSynchronously(WebCore::WorkerScriptFetcher&, WebCore::ScriptSourceCode const&) + 234 (WorkerOrWorkletScriptController.cpp:286)
6   WebCore                       	       0x298706045 WebCore::WorkerThread::evaluateScriptIfNecessary(WTF::String&) + 741 (WorkerThread.cpp:150)
7   WebCore                       	       0x2986dbff3 WebCore::WorkerOrWorkletThread::workerOrWorkletThread() + 723 (WorkerOrWorkletThread.cpp:175)
8   WebCore                       	       0x2987170e8 WebCore::WorkerThread::createThread()::$_4::operator()() const + 24 (WorkerThread.cpp:121)
9   WebCore                       	       0x298717089 WTF::Detail::CallableWrapper<WebCore::WorkerThread::createThread()::$_4, void>::call() + 25 (Function.h:53)
10  JavaScriptCore                	       0x27fcd1c02 WTF::Function<void ()>::operator()() const + 130
11  JavaScriptCore                	       0x27fd97538 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 408
12  JavaScriptCore                	       0x27fda3175 WTF::wtfThreadEntryPoint(void*) + 21
13  libsystem_pthread.dylib       	    0x7ff80dad64f4 _pthread_start + 125
14  libsystem_pthread.dylib       	    0x7ff80dad200f thread_start + 15

Comment 1 Chris Dumez 2022-02-01 14:57:52 PST

Created attachment 450571 [details]
Patch

Comment 2 Mark Lam 2022-02-01 14:58:49 PST

Comment on attachment 450571 [details]
Patch

r=me

Comment 3 Chris Dumez 2022-02-01 15:22:29 PST

Created attachment 450580 [details]
WIP Patch

Comment 4 Mark Lam 2022-02-02 17:13:21 PST

Created attachment 450719 [details]
proposed patch.

Comment 5 Mark Lam 2022-02-02 17:47:23 PST

Created attachment 450723 [details]
proposed patch.

Comment 6 Yusuke Suzuki 2022-02-02 18:17:46 PST

Comment on attachment 450723 [details]
proposed patch.

r=me

Comment 7 EWS 2022-02-03 08:39:51 PST

Committed r289057 (246764@main): <https://commits.webkit.org/246764@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450723 [details].

Comment 8 Radar WebKit Bug Importer 2022-02-03 08:40:22 PST

<rdar://problem/88436985>