Bug 235975

Summary: [Flatpak SDK] Using thin archives with ld.bfd results in linker errors
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, clopez, mcatanzaro, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://sourceware.org/bugzilla/show_bug.cgi?id=28138
Bug Depends on:    
Bug Blocks: 235476, 235979    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Adrian Perez 2022-02-01 14:15:45 PST 
While working on bug #235476 we noticed that the version of Binutils
that we get from the Freedesktop.org SDK contains a bug that results
in the ld.bfd linker failing to read thin archives. The linker fails
with the message:

    error adding symbols: malformed archive

This has been fixed in the following upstream bug:

    https://sourceware.org/bugzilla/show_bug.cgi?id=28138

We would want to include the two patches that fix the issue in our
Flatpak SDK.
Comment 1 Adrian Perez 2022-02-01 14:25:10 PST 
Created attachment 450568 [details]
Patch
Comment 2 EWS 2022-02-01 15:25:42 PST 
Committed r288916 (246655@main): <https://commits.webkit.org/246655@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450568 [details].
Comment 3 Radar WebKit Bug Importer 2022-02-01 15:26:19 PST 
<rdar://problem/88351562>
Comment 4 Adrian Perez 2022-02-02 03:34:30 PST 
Similar patches filed to upstream Freedesktop SDK:

 * For “master” → https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/7229
 * For “release/21.08” → https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/7241

We will be able to remove our local patch once fix lands in the 21.08
release *and* we update our SDK to point to the new tip of the branch.