Bug 235964

Summary: [GStreamer] Generate webrtc encoder src pad template based on supported platform encoders
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2022-02-01 09:57:23 PST
.
Attachments
Patch (6.11 KB, patch)
2022-02-01 09:59 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-02-01 09:59:58 PST
Created attachment 450542 [details] Patch
Víctor M. Jáquez L.
Comment 2 2022-02-01 23:21:09 PST
Comment on attachment 450542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450542&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:269 > + what about an assert or an error message if caps results empty?
Xabier Rodríguez Calvar
Comment 3 2022-02-01 23:26:53 PST
Comment on attachment 450542 [details] Patch I agree with Víctor, at least a WARNING or ERROR would be in order.
Philippe Normand
Comment 4 2022-02-02 01:26:23 PST
There is one already in webrtcVideoEncoderSetFormat()
EWS
Comment 5 2022-02-02 10:55:18 PST
Committed r288971 (246700@main): <https://commits.webkit.org/246700@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450542 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-02 10:56:17 PST
<rdar://problem/88390328>
Note You need to log in before you can comment on or make changes to this bug.