Bug 235964

Summary:

[GStreamer] Generate webrtc encoder src pad template based on supported platform encoders

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Philippe Normand 2022-02-01 09:57:23 PST

Comment 1 Philippe Normand 2022-02-01 09:59:58 PST

Created attachment 450542 [details]
Patch

Comment 2 Víctor M. Jáquez L. 2022-02-01 23:21:09 PST

Comment on attachment 450542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450542&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:269
> +

what about an assert or an error message if caps results empty?

Comment 3 Xabier Rodríguez Calvar 2022-02-01 23:26:53 PST

Comment on attachment 450542 [details]
Patch

I agree with Víctor, at least a WARNING or ERROR would be in order.

Comment 4 Philippe Normand 2022-02-02 01:26:23 PST

There is one already in webrtcVideoEncoderSetFormat()

Comment 5 EWS 2022-02-02 10:55:18 PST

Committed r288971 (246700@main): <https://commits.webkit.org/246700@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450542 [details].

Comment 6 Radar WebKit Bug Importer 2022-02-02 10:56:17 PST

<rdar://problem/88390328>