Bug 235961

Summary:

REGRESSION (r288869?): webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties is failing

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, gsnedders, jbedard, ntim, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=234672

Attachments:

Description	Flags
Patch	none

Description Ryan Haddad 2022-02-01 09:24:42 PST

Results history suggests that https://trac.webkit.org/changeset/288869/webkit caused the following webkitpy test to fail:

[1854/2186] webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties erred:
  Traceback (most recent call last):
    File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 267, in test_convert_prefixed_properties
      test_content = self.generate_test_content_properties_and_values(converter.prefixed_properties, converter.prefixed_property_values, 20, test_html)
    File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 402, in generate_test_content_properties_and_values
      test_content_property_values = self.generate_test_content(fully_property_values_list, num_test_properties_and_values, 'propvalue', test_content_properties[1])
    File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 409, in generate_test_content
      test_list.append(full_list[count])
  IndexError: list index out of range
  
https://results.webkit.org/?suite=webkitpy-tests&test=webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties

Comment 1 Radar WebKit Bug Importer 2022-02-01 09:25:19 PST

<rdar://problem/88332029>

Comment 2 Ryan Haddad 2022-02-01 09:32:14 PST

    def test_convert_prefixed_properties(self):
        """ Tests convert_prefixed_properties() file that has 20 properties requiring the -webkit- prefix:
        10 in one style block + 5 in another style
        block + 5 inline styles, including one with multiple prefixed properties.
        The properties in the test content are in all sorts of wack formatting.
        """

Comment 3 Ryan Haddad 2022-02-01 10:05:25 PST

I can reproduce this locally with:
test-webkitpy webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties

Comment 4 Sam Sneddon [:gsnedders] 2022-02-02 08:52:41 PST

Created attachment 450650 [details]
Patch

Comment 5 EWS 2022-02-02 10:33:19 PST

Committed r288962 (246691@main): <https://commits.webkit.org/246691@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450650 [details].