Bug 235942

Summary: [GTK][WPE] Switch to use ATSPI instead of ATK
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, annulen, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, ryuan.choi, samuel_white, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236036
https://bugs.webkit.org/show_bug.cgi?id=236215
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch
aperez: review+, aperez: commit-queue-
Patch aperez: review+

Description Carlos Garcia Campos 2022-02-01 01:26:58 PST 
Use ATSPI by default.
Comment 1 Carlos Garcia Campos 2022-02-01 01:28:51 PST 
Created attachment 450508 [details]
Patch
Comment 2 Carlos Garcia Campos 2022-02-01 01:34:01 PST 
Created attachment 450509 [details]
Patch
Comment 3 Adrian Perez 2022-02-01 03:10:12 PST 
Comment on attachment 450508 [details]
Patch

Patch LGTM, modulo making the style checker happy before landing.

I am glad to see the default being switched to the new implementation \o/
Comment 4 Carlos Garcia Campos 2022-02-01 03:11:38 PST 
(In reply to Adrian Perez from comment #3)
> Comment on attachment 450508 [details]
> Patch
> 
> Patch LGTM, modulo making the style checker happy before landing.
> 
> I am glad to see the default being switched to the new implementation \o/

Already submitted a new patch with the style issue fixed.
Comment 5 Adrian Perez 2022-02-01 03:13:16 PST 
(In reply to Carlos Garcia Campos from comment #4)
> (In reply to Adrian Perez from comment #3)
> > Comment on attachment 450508 [details]
> > Patch
> > 
> > Patch LGTM, modulo making the style checker happy before landing.
> > 
> > I am glad to see the default being switched to the new implementation \o/
> 
> Already submitted a new patch with the style issue fixed.

You sir, are fast! 🚀️
Comment 6 Carlos Garcia Campos 2022-02-01 04:29:11 PST 
Committed r288872 (246624@trunk): <https://commits.webkit.org/246624@trunk>