Bug 235939

Summary: [GPU Process] Remove DisplayList::Replayer::Delegate and DisplayList::RecorderImpl::Delegate
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, mmaxfield, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236508    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
wenson_hsieh: review+, ews-feeder: commit-queue-
Patch none

Said Abou-Hallawa
Reported 2022-01-31 21:42:53 PST
These classes are abstract classes and they are not overridden by any client right now. These unused classes should be removed after the display list stream connection refactoring.
Attachments
Patch (28.51 KB, patch)
2022-01-31 21:46 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (28.38 KB, patch)
2022-01-31 23:10 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (31.83 KB, patch)
2022-01-31 23:47 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (31.92 KB, patch)
2022-02-01 01:24 PST, Said Abou-Hallawa 		wenson_hsieh: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (31.91 KB, patch)
2022-02-02 11:42 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2022-01-31 21:46:27 PST
Created attachment 450498 [details] Patch
Said Abou-Hallawa
Comment 2 2022-01-31 23:10:29 PST
Created attachment 450501 [details] Patch
Said Abou-Hallawa
Comment 3 2022-01-31 23:47:06 PST
Created attachment 450503 [details] Patch
Said Abou-Hallawa
Comment 4 2022-02-01 01:24:23 PST
Created attachment 450507 [details] Patch
Wenson Hsieh
Comment 5 2022-02-01 10:55:02 PST
Comment on attachment 450507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450507&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:94 > + return *imageIdentifier; Nit - let's keep these return types on line 94 and 97 consistent (maybe by getting the value inside the optional in both cases).
Said Abou-Hallawa
Comment 6 2022-02-02 11:42:36 PST
Created attachment 450681 [details] Patch
EWS
Comment 7 2022-02-02 13:09:55 PST
Committed r288991 (246710@main): <https://commits.webkit.org/246710@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450681 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-02 13:10:18 PST
<rdar://problem/88397449>
Note You need to log in before you can comment on or make changes to this bug.