Bug 235938

Summary:

Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, darin, dbarton, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, hi, jcraig, jdiggs, jer.noble, joepeck, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, samuel_white, schenney, sergio, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	zalan: review+, ews-feeder: commit-queue-
Patch for committing	ews-feeder: commit-queue-
Patch for committing	ews-feeder: commit-queue-
Patch for committing	ews-feeder: commit-queue-
Patch for committing	none

Description Myles C. Maxfield 2022-01-31 20:33:22 PST

Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()

Comment 1 Myles C. Maxfield 2022-01-31 20:34:45 PST

Created attachment 450493 [details]
Patch

Comment 2 Myles C. Maxfield 2022-01-31 20:49:05 PST

Created attachment 450494 [details]
Patch

Comment 3 Myles C. Maxfield 2022-01-31 20:59:11 PST

Created attachment 450495 [details]
Patch for committing

Comment 4 Myles C. Maxfield 2022-01-31 21:03:16 PST

Created attachment 450496 [details]
Patch for committing

Comment 5 Myles C. Maxfield 2022-01-31 21:29:43 PST

Created attachment 450497 [details]
Patch for committing

Comment 6 Myles C. Maxfield 2022-01-31 21:56:45 PST

Created attachment 450499 [details]
Patch for committing

Comment 7 EWS 2022-01-31 23:45:16 PST

Committed r288868 (246620@main): <https://commits.webkit.org/246620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450499 [details].

Comment 8 Radar WebKit Bug Importer 2022-01-31 23:46:17 PST

<rdar://problem/88314722>

Comment 9 Darin Adler 2022-02-01 08:54:29 PST

(In reply to Myles C. Maxfield from comment #0)
> Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to
> fontMetricsOfPrimaryFont()

But do we need the word "font" twice in this name.

Comment 10 Myles C. Maxfield 2022-02-01 09:17:45 PST

(In reply to Darin Adler from comment #9)
> (In reply to Myles C. Maxfield from comment #0)
> > Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to
> > fontMetricsOfPrimaryFont()
> 
> But do we need the word "font" twice in this name.

I thought that would be better than “primaryFontsMetrics” because the missing apostrophe makes it unclear whether “font” is plural or possessive.

Also making it a wordy name has the extra benefit that people might be less likely to call it in the future 😅

Comment 11 Myles C. Maxfield 2022-02-01 09:20:16 PST

(And also better than primaryFontMetrics because it’s unclear whether the “primary” applies to the font or to the metrics.)

Maybe “metricsOfPrimaryFont()” is better?

Comment 12 Darin Adler 2022-02-01 09:33:18 PST

(In reply to Myles C. Maxfield from comment #11)
> Maybe “metricsOfPrimaryFont()” is better?

Yes, if I caught you in time I would have suggested that. Since fontMetricsOfPrimaryFont is a long unique name we can do it mechanically. do-webcore-rename can do it for us.

Comment 13 Myles C. Maxfield 2022-02-01 21:13:01 PST

Committed r288942 (246672@trunk): <https://commits.webkit.org/246672@trunk>