Bug 235938

Summary: Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, darin, dbarton, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, hi, jcraig, jdiggs, jer.noble, joepeck, kondapallykalyan, macpherson, menard, mifenton, pangle, pdr, philipj, sabouhallawa, samuel_white, schenney, sergio, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
zalan: review+, ews-feeder: commit-queue-
Patch for committing
ews-feeder: commit-queue-
Patch for committing
ews-feeder: commit-queue-
Patch for committing
ews-feeder: commit-queue-
Patch for committing none

Myles C. Maxfield
Reported 2022-01-31 20:33:22 PST
Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()
Attachments
Patch (99.88 KB, patch)
2022-01-31 20:34 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (100.91 KB, patch)
2022-01-31 20:49 PST, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (103.02 KB, patch)
2022-01-31 20:59 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (105.12 KB, patch)
2022-01-31 21:03 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (105.97 KB, patch)
2022-01-31 21:29 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (107.64 KB, patch)
2022-01-31 21:56 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-01-31 20:34:45 PST
Created attachment 450493 [details] Patch
Myles C. Maxfield
Comment 2 2022-01-31 20:49:05 PST
Created attachment 450494 [details] Patch
Myles C. Maxfield
Comment 3 2022-01-31 20:59:11 PST
Created attachment 450495 [details] Patch for committing
Myles C. Maxfield
Comment 4 2022-01-31 21:03:16 PST
Created attachment 450496 [details] Patch for committing
Myles C. Maxfield
Comment 5 2022-01-31 21:29:43 PST
Created attachment 450497 [details] Patch for committing
Myles C. Maxfield
Comment 6 2022-01-31 21:56:45 PST
Created attachment 450499 [details] Patch for committing
EWS
Comment 7 2022-01-31 23:45:16 PST
Committed r288868 (246620@main): <https://commits.webkit.org/246620@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450499 [details].
Radar WebKit Bug Importer
Comment 8 2022-01-31 23:46:17 PST
<rdar://problem/88314722>
Darin Adler
Comment 9 2022-02-01 08:54:29 PST
(In reply to Myles C. Maxfield from comment #0) > Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to > fontMetricsOfPrimaryFont() But do we need the word "font" twice in this name.
Myles C. Maxfield
Comment 10 2022-02-01 09:17:45 PST
(In reply to Darin Adler from comment #9) > (In reply to Myles C. Maxfield from comment #0) > > Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to > > fontMetricsOfPrimaryFont() > > But do we need the word "font" twice in this name. I thought that would be better than “primaryFontsMetrics” because the missing apostrophe makes it unclear whether “font” is plural or possessive. Also making it a wordy name has the extra benefit that people might be less likely to call it in the future 😅
Myles C. Maxfield
Comment 11 2022-02-01 09:20:16 PST
(And also better than primaryFontMetrics because it’s unclear whether the “primary” applies to the font or to the metrics.) Maybe “metricsOfPrimaryFont()” is better?
Darin Adler
Comment 12 2022-02-01 09:33:18 PST
(In reply to Myles C. Maxfield from comment #11) > Maybe “metricsOfPrimaryFont()” is better? Yes, if I caught you in time I would have suggested that. Since fontMetricsOfPrimaryFont is a long unique name we can do it mechanically. do-webcore-rename can do it for us.
Myles C. Maxfield
Comment 13 2022-02-01 21:13:01 PST
Committed r288942 (246672@trunk): <https://commits.webkit.org/246672@trunk>
Note You need to log in before you can comment on or make changes to this bug.