[Modules] ES module link errors should be reported unmuted from script elements

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Asumu Takikawa]

Currently some WPT tests related to ES module link errors are failing (https://github.com/WebKit/WebKit/blob/4b4206d9a657984bcd1c01379a62de494afcaa69/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/instantiation-error-1-expected.txt) because the linking errors are muted (i.e., the error message is just "Script error.") and don't include the full error message/error value in the ErrorEvent. Since module scripts shouldn't have muted errors, these messages should get reported in full.

[Asumu Takikawa]

Created attachment 450488 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 450488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450488&action=review

r=me

> Source/WebCore/bindings/js/ScriptController.cpp:215
> +        reportException(&lexicalGlobalObject, evaluationException, nullptr, /* fromModule */ true);

I recommend using a boolean variable here to name it.

constexpr bool fromModule = true;
reportException(&lexicalGlobalObject, evaluationException, nullptr, fromModule);

[Asumu Takikawa]

Created attachment 450653 [details]
Patch

[EWS]

Committed r288989 (246708@main): <https://commits.webkit.org/246708@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450653 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88396643>