Bug 235882

Summary:

ServiceWorkerNavigationPreloader should only be used once

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	ews-feeder: commit-queue-

Description youenn fablet 2022-01-31 03:04:49 PST

<rdar://88226432>

Comment 1 youenn fablet 2022-01-31 03:13:33 PST

Created attachment 450394 [details]
Patch

Comment 2 Chris Dumez 2022-01-31 11:41:50 PST

Comment on attachment 450394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450394&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:398
> +        RELEASE_LOG_ERROR(ServiceWorker, "ServiceWorkerFetchTask::loadBodyFromPreloader preloader is null");

Could you please add a SWFETCH_RELEASE_LOG_ERROR() for consistency with SWFETCH_RELEASE_LOG()?

Comment 3 youenn fablet 2022-02-01 23:33:34 PST

Created attachment 450619 [details]
Patch for landing

Comment 4 EWS 2022-02-02 02:16:18 PST

Committed r288949 (246678@main): <https://commits.webkit.org/246678@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450619 [details].