Bug 235828

Summary: [macOS][WP] Add required syscall
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2022-01-28 10:05:52 PST 
Add required syscall to WebContent process' sandbox on macOS.
Comment 1 Per Arne Vollan 2022-01-28 10:06:07 PST 
<rdar://88177392>
Comment 2 Per Arne Vollan 2022-01-28 10:07:20 PST 
Created attachment 450248 [details]
Patch
Comment 3 Per Arne Vollan 2022-01-28 10:11:09 PST 
Comment on attachment 450248 [details]
Patch

Thanks for reviewing!
Comment 4 EWS 2022-01-28 11:08:23 PST 
Committed r288750 (246543@main): <https://commits.webkit.org/246543@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450248 [details].
Comment 5 Per Arne Vollan 2022-01-28 12:36:41 PST 
Reopening to attach new patch.
Comment 6 Per Arne Vollan 2022-01-28 12:36:42 PST 
Created attachment 450267 [details]
Patch
Comment 7 Alexey Proskuryakov 2022-01-28 18:47:44 PST 
Comment on attachment 450267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450267&action=review

> Source/WebKit/ChangeLog:9
> +        Follow-up fix after r288750. Only allow syscall on older OS versions.

I think that the patch implements "on older macOS versions or on macCatalyst", is that the intention?
Comment 8 Per Arne Vollan 2022-01-28 19:34:34 PST 
(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 450267 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450267&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        Follow-up fix after r288750. Only allow syscall on older OS versions.
> 
> I think that the patch implements "on older macOS versions or on
> macCatalyst", is that the intention?

Yes, that is the intention.

Thanks for reviewing!
Comment 9 Brent Fulgham 2022-02-01 12:35:29 PST 
Comment on attachment 450267 [details]
Patch

r=me
Comment 10 Per Arne Vollan 2022-02-01 12:39:18 PST 
Comment on attachment 450267 [details]
Patch

Thanks for reviewing!
Comment 11 EWS 2022-02-01 13:10:35 PST 
Committed r288908 (246650@main): <https://commits.webkit.org/246650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450267 [details].