Summary: | Add support for GNU mode RVCT compilation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Laszlo Gombos <laszlo.gombos> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | hausmann, mrowe, vestbo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Other | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 27065 | ||||||||||
Attachments: |
|
Description
Laszlo Gombos
2009-01-27 18:52:46 PST
Created attachment 27093 [details]
Patch to support GNU mode RVCT compilation
Patch to support GNU mode RVCT compilation
Checking both COMPILER(GCC) and defined(__GNUC__) seem redundant. Created attachment 27103 [details]
Revised patch based on feedback
Created attachment 27179 [details]
Revised patch to make it more future proof and readable
Moved the COMPILER(RVCT) rules in from of the COMPILER(GCC) definition, so that when COMPILER(GCC) is defined, we can just check for !COMPILER(RVCT).
Extra comment added to make the code more readable !
Comment on attachment 27179 [details]
Revised patch to make it more future proof and readable
Looks good to me. When landing I'll add a note to the ChangeLog, but otherwise it's ready to go.
|