Bug 235746 – Roll ANGLE to Feb 18 2022 (78c64dd74ee5)

• Component: ANGLE
• Status: RESOLVED FIXED

[Kyle Piddington]

Roll ANGLE to Jan 27 2022 (c4a9d4169)

[Kyle Piddington]

Created attachment 450198 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Radar WebKit Bug Importer]

<rdar://problem/88464021>

[Kyle Piddington]

Created attachment 452573 [details]
Patch

[Kyle Piddington]

Created attachment 452582 [details]
Patch

[Kenneth Russell]

Comment on attachment 452582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452582&action=review

Looks great - I reviewed changes.diff and all the updates to src/libANGLE/renderer/metal/ . This roll will surely fix a lot of content in Safari. I defer to Dean's earlier review, though.

> Source/ThirdParty/ANGLE/changes.diff:263
> +diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp

We need to upstream this bug fix in anglebug.com/6920 .

> Source/ThirdParty/ANGLE/changes.diff:317
> +diff --git a/src/libANGLE/Surface.cpp b/src/libANGLE/Surface.cpp

Same for this memory leak fix - also part of https://webkit.org/b/235284 - to anglebug.com/6920 .

> Source/ThirdParty/ANGLE/changes.diff:512
> ++    // FIXME: Check that the format matches this IOSurface plane for pixel formats that we know of.

Need to track this fix in WebKit and figure out what to do upstream, too.

> Source/ThirdParty/ANGLE/changes.diff:818
> +     size_t mEstimatedByteSize = 0;

It's subtle but it looks like this diff is actually caused by the introduction in WebKit of std::enable_shared_from_this below. We should upstream these diffs.

[Kenneth Russell]

In the EWS failures:
http/wpt/push-api/onpush-disabled.html is unrelated

webgl/1.0.3/conformance/extensions/webgl-compressed-texture-pvrtc.html on the iOS Simulator is producing an error in the GPU process:

-[MTLSerializerBlitCommandEncoder copyFromBuffer:sourceOffset:sourceBytesPerRow:sourceBytesPerImage:sourceSize:toTexture:destinationSlice:destinationLevel:destinationOrigin:options:]_block_invoke:465: failed assertion `Error creating pipeline state Error Domain=CompilerError Code=2 "Compiler encountered an internal error" UserInfo={NSLocalizedDescription=Compiler encountered an internal error} from pvrtc2'

There were a few changes to compressed texture support in this ANGLE roll which might have affected the PVRTC format.

[Kyle Piddington]

Created attachment 453039 [details]
Patch

[Kyle Piddington]

Rolled back PVRTC support in the sim. This isn't a regression, as we had these unsupported before. It would be nice to get PVRTC working, but not as part of a roll.

[Kenneth Russell]

Comment on attachment 453039 [details]
Patch

Looks good to me to remove the PVRTC formats from the iOS simulator. These weren't working the last time I tested them.

Dean reviewed this earlier, so please feel free to use "Reviewed by Dean Jackson.".

[Kyle Piddington]

Created attachment 453151 [details]
Patch for landing

[EWS]

Committed r290479 (247776@main): <https://commits.webkit.org/247776@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453151 [details].

[Brent Fulgham]

This fix shipped with Safari 15.5 (all platforms).