Bug 235741

Summary:

Web Inspector: Add another Protocol Version (iOS 15.4)

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1.0	none
Patch v1.1 - Fix a compatibility comment	none

Description Patrick Angle 2022-01-27 15:14:57 PST

<rdar://80792134>

Comment 1 Patrick Angle 2022-01-27 15:22:42 PST

Created attachment 450189 [details]
Patch v1.0

Comment 2 Devin Rousso 2022-01-27 15:37:47 PST

Comment on attachment 450189 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=450189&action=review

r=me, awesome!

> Source/WebInspectorUI/UserInterface/Protocol/Legacy/15.4/InspectorBackendCommands.js:37
> +InspectorBackend.registerCommand("Animation.requestEffectTarget", null, [{"name": "animationId", "type": "string"}], ["nodeId"]);

Since this is still `nodeId`, we should update the comment in `WI.Animation.prototype.requestEffectTarget` to say "iOS 15.4" instead.

Comment 3 Patrick Angle 2022-01-28 08:58:41 PST

Created attachment 450237 [details]
Patch v1.1 - Fix a compatibility comment

Comment 4 EWS 2022-01-28 09:30:50 PST

Committed r288743 (246536@main): <https://commits.webkit.org/246536@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450237 [details].