Bug 235728

Summary: AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2022-01-27 13:01:01 PST 
AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded.
Comment 1 Radar WebKit Bug Importer 2022-01-27 13:01:12 PST 
<rdar://problem/88149344>
Comment 2 Andres Gonzalez 2022-01-27 13:08:26 PST 
Created attachment 450169 [details]
Patch
Comment 3 chris fleizach 2022-01-27 13:17:07 PST 
Comment on attachment 450169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450169&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538
> +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool  updateChildrenIfNeeded)

too many spaces
"bool updateChildrenIfNeeded"
Comment 4 Andres Gonzalez 2022-01-27 13:28:21 PST 
Created attachment 450170 [details]
Patch
Comment 5 Andres Gonzalez 2022-01-27 13:30:14 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 450169 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450169&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538
> > +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool  updateChildrenIfNeeded)
> 
> too many spaces
> "bool updateChildrenIfNeeded"

Fixed.
Comment 6 EWS 2022-01-27 14:24:41 PST 
Committed r288703 (246501@main): <https://commits.webkit.org/246501@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450170 [details].