| Summary: | AX: Isolated tree object frames no longer encode content offsets, so hit testing should be updated accordingly | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andresg_22, cfleizach, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 450193 [details]
Patch
My original comment should say: as **NOT** applying this content offset results in hit testing working incorrectly It's correct in the Changelog. Committed r288741 (246534@main): <https://commits.webkit.org/246534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450193 [details]. |
In -[WKAccessibilityWebPageObjectMac accessibilityHitTest], we have a special isolated tree case: // Isolated tree frames have the offset encoded into them so we don't need to undo here. #if ENABLE(ACCESSIBILITY_ISOLATED_TREE) applyContentOffset = !WebCore::AXObjectCache::isIsolatedTreeEnabled(); #endif The statement in the comment no longer seems to be true, as applying this content offset results in hit testing working incorrectly -- specifically, you have to hit test for a larger y-value than your target is actually located at.