Bug 235718

Summary: Add layout test for Bug 235645
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, darin, ews-watchlist, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/web-platform-tests/wpt/pull/32571
See Also: https://bugs.webkit.org/show_bug.cgi?id=235645
Bug Depends on:    
Bug Blocks: 220502    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2022-01-27 08:33:45 PST
Add layout test for Bug 235645. Clearly, our test coverage was insufficient as it didn't catch the issue.
Attachments
Patch (2.01 KB, patch)
2022-01-27 08:48 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2022-01-27 09:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-01-27 08:48:05 PST
Created attachment 450142 [details] Patch
Darin Adler
Comment 2 2022-01-27 08:53:02 PST
Comment on attachment 450142 [details] Patch Maybe WPT should have tests like this one too?
Chris Dumez
Comment 3 2022-01-27 09:38:52 PST
Created attachment 450147 [details] Patch
Chris Dumez
Comment 4 2022-01-27 09:39:17 PST
Ok, now written as a WPT test. Will send a PR.
EWS Watchlist
Comment 5 2022-01-27 09:40:20 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Chris Dumez
Comment 6 2022-01-27 09:44:34 PST
Upstream PR: https://github.com/web-platform-tests/wpt/pull/32571
EWS
Comment 7 2022-01-27 12:28:15 PST
Committed r288695 (246493@main): <https://commits.webkit.org/246493@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450147 [details].
Radar WebKit Bug Importer
Comment 8 2022-01-27 12:29:17 PST
<rdar://problem/88147811>
Note You need to log in before you can comment on or make changes to this bug.