| Summary: | AXLogger::add should not cause tree updates via children() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 450137 [details]
Patch
Committed r288676 (246482@main): <https://commits.webkit.org/246482@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450137 [details]. |
AXLogger::add(TextStream&, const RefPtr<AXCoreObject>&, bool) currently calls the update version of children, causing behavior to potentially be different between builds with logging enabled and logging disabled. void AXLogger::add(TextStream& stream, const RefPtr<AXCoreObject>& object, bool recursive) { ...truncated... if (recursive) { for (auto& child : object->children()) add(stream, child, true); } ...truncated } The logger should only read the current state of the object / tree, never modify it.