Bug 235712

Summary: [CSS Container Queries] Basic parsing support for query syntax
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, macpherson, menard, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch
none
Patch for landing none

Attachments
Patch (17.13 KB, patch)
2022-01-27 07:13 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.75 KB, patch)
2022-01-27 08:35 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-01-27 07:13:07 PST
Created attachment 450134 [details] Patch
Darin Adler
Comment 2 2022-01-27 07:57:57 PST
Comment on attachment 450134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450134&action=review > Source/WebCore/css/parser/MediaQueryParser.cpp:274 > + return !equalIgnoringASCIICase(token.value(), "size"); I suspect this can use the slightly more efficient equalLettersIgnoringASCIICase
Antti Koivisto
Comment 3 2022-01-27 08:35:14 PST
Created attachment 450141 [details] Patch for landing
EWS
Comment 4 2022-01-27 09:50:44 PST
Committed r288675 (246481@main): <https://commits.webkit.org/246481@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450141 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-27 09:51:27 PST
<rdar://problem/88138714>
Note You need to log in before you can comment on or make changes to this bug.