Bug 235701

Summary:

[WPE][a11y] Add option to build with ATSPI

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WPE WebKit

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aperez: review+, ews-feeder: commit-queue-

Description Carlos Garcia Campos 2022-01-27 02:51:15 PST

Comment 1 Carlos Garcia Campos 2022-01-27 02:53:19 PST

Created attachment 450119 [details]
Patch

Comment 2 Adrian Perez 2022-01-27 04:50:41 PST

Comment on attachment 450119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450119&action=review

> Source/WebCore/PlatformWPE.cmake:127
> +    )

IIRC we have a similar (if not the same) custom command in PlatformGTK.cmake;
it would be nice to factor out this functionality in a CMake function at some
point. Could be a follow up patch later on.

> Source/cmake/OptionsWPE.cmake:90
> +WEBKIT_OPTION_DEFINE(USE_ATSPI "Whether to use the Atspi a11y implementation instead of ATK." PRIVATE OFF)

Typo: Atspi → ATSPI

(All caps because it is an acronym, wasn't it?)

Comment 3 Carlos Garcia Campos 2022-01-27 23:06:07 PST

Committed r288731 (246524@trunk): <https://commits.webkit.org/246524@trunk>