Bug 235701

Summary: [WPE][a11y] Add option to build with ATSPI
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aperez: review+, ews-feeder: commit-queue-

Carlos Garcia Campos
Reported 2022-01-27 02:51:15 PST
.
Attachments
Patch (12.37 KB, patch)
2022-01-27 02:53 PST, Carlos Garcia Campos 		aperez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2022-01-27 02:53:19 PST
Created attachment 450119 [details] Patch
Adrian Perez
Comment 2 2022-01-27 04:50:41 PST
Comment on attachment 450119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450119&action=review > Source/WebCore/PlatformWPE.cmake:127 > + ) IIRC we have a similar (if not the same) custom command in PlatformGTK.cmake; it would be nice to factor out this functionality in a CMake function at some point. Could be a follow up patch later on. > Source/cmake/OptionsWPE.cmake:90 > +WEBKIT_OPTION_DEFINE(USE_ATSPI "Whether to use the Atspi a11y implementation instead of ATK." PRIVATE OFF) Typo: Atspi → ATSPI (All caps because it is an acronym, wasn't it?)
Carlos Garcia Campos
Comment 3 2022-01-27 23:06:07 PST
Committed r288731 (246524@trunk): <https://commits.webkit.org/246524@trunk>
Note You need to log in before you can comment on or make changes to this bug.