Bug 235693

Summary: Migrate _UITextSearching implementation to be backed by WebFoundTextRangeController
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235691    
Bug Blocks: 235830, 250078    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
thorton: review+, ews-feeder: commit-queue-
Patch for landing none

Description Aditya Keerthi 2022-01-26 23:42:10 PST 
...
Comment 1 Aditya Keerthi 2022-01-26 23:42:19 PST 
rdar://88117303
Comment 2 Aditya Keerthi 2022-01-27 11:58:05 PST 
Created attachment 450164 [details]
Patch
Comment 3 Aditya Keerthi 2022-01-27 14:32:14 PST 
Created attachment 450180 [details]
Patch
Comment 4 Aditya Keerthi 2022-01-27 23:40:15 PST 
Created attachment 450208 [details]
Patch
Comment 5 Tim Horton 2022-01-28 12:23:05 PST 
Comment on attachment 450208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450208&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10084
> +    _page->findTextRangesForStringMatches(string, findOptions, 1000, [string, aggregator = retainPtr(aggregator)](const Vector<WebKit::WebFoundTextRange> ranges) {

Not a regression but kind of odd that this `1000` is just chilling here inline without a name.
Comment 6 Aditya Keerthi 2022-01-28 14:04:58 PST 
Created attachment 450275 [details]
Patch for landing
Comment 7 Aditya Keerthi 2022-01-28 14:06:00 PST 
(In reply to Tim Horton from comment #5)
> Comment on attachment 450208 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450208&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10084
> > +    _page->findTextRangesForStringMatches(string, findOptions, 1000, [string, aggregator = retainPtr(aggregator)](const Vector<WebKit::WebFoundTextRange> ranges) {
> 
> Not a regression but kind of odd that this `1000` is just chilling here
> inline without a name.

Added a comment and a variable.
Comment 8 EWS 2022-01-28 15:13:52 PST 
Committed r288762 (246550@main): <https://commits.webkit.org/246550@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450275 [details].