Bug 235693

Summary: Migrate _UITextSearching implementation to be backed by WebFoundTextRangeController
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235691    
Bug Blocks: 235830, 250078    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
thorton: review+, ews-feeder: commit-queue-
Patch for landing none

Aditya Keerthi
Reported 2022-01-26 23:42:10 PST
...
Attachments
Patch (20.29 KB, patch)
2022-01-27 11:58 PST, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (20.29 KB, patch)
2022-01-27 14:32 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (21.05 KB, patch)
2022-01-27 23:40 PST, Aditya Keerthi 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (21.77 KB, patch)
2022-01-28 14:04 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2022-01-26 23:42:19 PST
rdar://88117303
Aditya Keerthi
Comment 2 2022-01-27 11:58:05 PST
Created attachment 450164 [details] Patch
Aditya Keerthi
Comment 3 2022-01-27 14:32:14 PST
Created attachment 450180 [details] Patch
Aditya Keerthi
Comment 4 2022-01-27 23:40:15 PST
Created attachment 450208 [details] Patch
Tim Horton
Comment 5 2022-01-28 12:23:05 PST
Comment on attachment 450208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450208&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10084 > + _page->findTextRangesForStringMatches(string, findOptions, 1000, [string, aggregator = retainPtr(aggregator)](const Vector<WebKit::WebFoundTextRange> ranges) { Not a regression but kind of odd that this `1000` is just chilling here inline without a name.
Aditya Keerthi
Comment 6 2022-01-28 14:04:58 PST
Created attachment 450275 [details] Patch for landing
Aditya Keerthi
Comment 7 2022-01-28 14:06:00 PST
(In reply to Tim Horton from comment #5) > Comment on attachment 450208 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450208&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10084 > > + _page->findTextRangesForStringMatches(string, findOptions, 1000, [string, aggregator = retainPtr(aggregator)](const Vector<WebKit::WebFoundTextRange> ranges) { > > Not a regression but kind of odd that this `1000` is just chilling here > inline without a name. Added a comment and a variable.
EWS
Comment 8 2022-01-28 15:13:52 PST
Committed r288762 (246550@main): <https://commits.webkit.org/246550@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450275 [details].
Note You need to log in before you can comment on or make changes to this bug.