Bug 235685

Summary: Add fuzzy match data to WPT
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Tools / TestsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, darin, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/32692
Bug Depends on:    
Bug Blocks: 231828    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Jon Lee 2022-01-26 20:42:21 PST 
.
Comment 1 Jon Lee 2022-01-27 00:36:29 PST 
Created attachment 450108 [details]
Patch
Comment 2 EWS Watchlist 2022-01-27 00:38:14 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Jon Lee 2022-01-27 00:58:35 PST 
Created attachment 450113 [details]
Patch
Comment 4 Jon Lee 2022-01-27 09:46:14 PST 
Created attachment 450148 [details]
Patch
Comment 5 Darin Adler 2022-01-28 10:56:57 PST 
Comment on attachment 450148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450148&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +        Add fuzzy match data to WPT

How will upstreaming of this work? Is this cross-platform setting that we all have to agree on? Will this be obliterated when we update to newer versions of WPT?
Comment 6 Darin Adler 2022-01-28 10:57:22 PST 
Comment on attachment 450148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450148&action=review

>> LayoutTests/imported/w3c/ChangeLog:3
>> +        Add fuzzy match data to WPT
> 
> How will upstreaming of this work? Is this cross-platform setting that we all have to agree on? Will this be obliterated when we update to newer versions of WPT?

I meant "a cross-browser setting"
Comment 7 Jon Lee 2022-01-28 12:02:33 PST 
(In reply to Darin Adler from comment #5)
> Comment on attachment 450148 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450148&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:3
> > +        Add fuzzy match data to WPT
> 
> How will upstreaming of this work? Is this cross-platform setting that we
> all have to agree on? Will this be obliterated when we update to newer
> versions of WPT?

I'm going to adjust the close tags for some of these tests, but as part of it will begin the process of upstreaming the changes. It is a cross-browser setting that everyone needs to agree on, hence the 0 lower bound.
Comment 8 Jon Lee 2022-01-28 12:03:03 PST 
(In reply to Jon Lee from comment #7)
> I'm going to adjust the close tags for some of these tests, but as part of
> it will begin the process of upstreaming the changes.
Meaning I'm going to upload a new patch.
Comment 9 Jon Lee 2022-01-28 17:45:06 PST 
Created attachment 450296 [details]
Patch
Comment 10 Radar WebKit Bug Importer 2022-02-02 20:43:18 PST 
<rdar://problem/88416387>
Comment 11 Darin Adler 2022-02-03 04:29:00 PST 
Comment on attachment 450296 [details]
Patch

Need a rebased patch
Comment 12 Jon Lee 2022-02-03 22:58:22 PST 
Committed r289105 (?): <https://commits.webkit.org/r289105>
Comment 13 Jon Lee 2022-02-03 22:59:08 PST 
Submitted a patch that pulls the latest version of WPT test to put this patch on top of.
Comment 14 Jon Lee 2022-02-03 23:24:56 PST 
Created attachment 450869 [details]
Patch
Comment 15 Jon Lee 2022-02-03 23:30:47 PST 
Created attachment 450870 [details]
Patch
Comment 16 Jon Lee 2022-02-03 23:32:25 PST 
Created attachment 450871 [details]
Patch
Comment 17 Jon Lee 2022-02-03 23:33:07 PST 
Created attachment 450872 [details]
Patch
Comment 18 Jon Lee 2022-02-03 23:36:00 PST 
Created attachment 450873 [details]
Patch
Comment 19 Jon Lee 2022-02-03 23:38:12 PST 
Created attachment 450874 [details]
Patch
Comment 20 Jon Lee 2022-02-03 23:41:05 PST 
Created attachment 450875 [details]
Patch
Comment 21 Jon Lee 2022-02-03 23:41:50 PST 
Created attachment 450876 [details]
Patch
Comment 22 Jon Lee 2022-02-03 23:44:43 PST 
Created attachment 450877 [details]
Patch
Comment 23 Jon Lee 2022-02-03 23:45:35 PST 
Created attachment 450878 [details]
Patch
Comment 24 Jon Lee 2022-02-03 23:45:56 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/32692
Comment 25 Jon Lee 2022-02-04 09:18:09 PST 
The test failure on Mac-wk1 appears to not be related to the patch. It flakily fails on the EWS bot. https://results.webkit.org/?suite=layout-tests&test=inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html
Comment 26 Jon Lee 2022-02-04 16:07:28 PST 
Changeling found its way in the wrong place, oops. But it's in there!
Committed r289141: <https://commits.webkit.org/r289141>