Bug 235630

Summary: [WebGPU] Make sure WGSLUnitTests can call into WGSL
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rmorisset: review+

Myles C. Maxfield
Reported 2022-01-26 00:32:31 PST
[WebGPU] Make sure WGSLUnitTests can call into WGSL
Attachments
Patch (2.50 KB, patch)
2022-01-26 00:33 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2022-01-26 00:34 PST, Myles C. Maxfield 		rmorisset: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-01-26 00:33:47 PST
Created attachment 450000 [details] Patch
Myles C. Maxfield
Comment 2 2022-01-26 00:34:52 PST
Created attachment 450001 [details] Patch
EWS
Comment 3 2022-01-26 13:59:17 PST
Committed r288643 (246453@main): <https://commits.webkit.org/246453@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450001 [details].
Radar WebKit Bug Importer
Comment 4 2022-01-26 14:00:17 PST
<rdar://problem/88094267>
Darin Adler
Comment 5 2022-01-26 15:21:43 PST
Comment on attachment 450001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450001&action=review > Source/WebGPU/ChangeLog:9 > + (WGSL::staticCheck): Apparently /usr/local/include/AssertMacros.h #defines "check" In paste we have worked around such things with "#undef". See the "#undef new" and "#undef delete" in config.h. And "#undef try" and "#undef catch" in WebCorePrefix.h. But renaming our function is also OK.
Robin Morisset
Comment 6 2022-01-27 01:11:48 PST
Comment on attachment 450001 [details] Patch r=me
Note You need to log in before you can comment on or make changes to this bug.