Bug 235607

Summary: No breakpoints hit on github.com, and some are invalid
Product: WebKit Reporter: Dean Jackson <dino>
Component: Web InspectorAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: amakhrov, chi187, commit-queue, dan, evan.exe, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, michal64128, msaboff, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239134
Bug Depends on: 236141    
Bug Blocks:    
Attachments:
Description Flags
Screenshot
none
Patch v1.0 - Needs tests
none
Patch v1.1 - Added tests, fixed cases where string token start offset was incorrect.
none
Patch v1.2 - Pass parser-xml-close-comment.html again
none
Patch v1.3 - Review nit
none
Patch v1.4 - Fix handling multi-line comment and string error cases
none
Patch v1.4a - Fix handling multi-line comment and string error cases
none
Patch v1.5 - Add JSTests cases none

Dean Jackson
Reported 2022-01-25 13:43:52 PST
Created attachment 449962 [details] Screenshot 1. Go to github.com when not logged in (so you get the globe animation, not your dashboard). 2. Open the inspector, search for "getContext(" and put a breakpoint on the line with "Y = e.getContext(F, H);" 3. Put another breakpoint just below that, on the line with "const x = {". Notice that it is not resolved/enabled. 4. Reload the page. None of the breakpoints are hit.
Attachments
Screenshot (984.40 KB, image/png)
2022-01-25 13:43 PST, Dean Jackson 		no flags
Details
Patch v1.0 - Needs tests (2.16 KB, patch)
2022-01-25 17:37 PST, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 - Added tests, fixed cases where string token start offset was incorrect. (9.90 KB, patch)
2022-01-31 22:11 PST, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.2 - Pass parser-xml-close-comment.html again (9.93 KB, patch)
2022-01-31 23:27 PST, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.3 - Review nit (9.97 KB, patch)
2022-02-02 08:33 PST, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.4 - Fix handling multi-line comment and string error cases (10.26 KB, patch)
2022-03-22 09:31 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.4a - Fix handling multi-line comment and string error cases (10.86 KB, patch)
2022-03-22 11:05 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.5 - Add JSTests cases (12.14 KB, patch)
2022-03-22 13:45 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-25 13:46:01 PST
<rdar://problem/88042400>
Patrick Angle
Comment 2 2022-01-25 17:37:06 PST
Created attachment 449986 [details] Patch v1.0 - Needs tests
Patrick Angle
Comment 3 2022-01-31 22:11:53 PST
Created attachment 450500 [details] Patch v1.1 - Added tests, fixed cases where string token start offset was incorrect.
Patrick Angle
Comment 4 2022-01-31 23:27:56 PST
Created attachment 450502 [details] Patch v1.2 - Pass parser-xml-close-comment.html again
Yusuke Suzuki
Comment 5 2022-02-01 17:43:05 PST
Comment on attachment 450502 [details] Patch v1.2 - Pass parser-xml-close-comment.html again View in context: https://bugs.webkit.org/attachment.cgi?id=450502&action=review r=me > Source/JavaScriptCore/parser/Lexer.cpp:2493 > } I know it is pre-existing, but this }'s place is wrong, so can you unindent one level?
Joseph Pecoraro
Comment 6 2022-02-01 20:26:18 PST
Comment on attachment 450502 [details] Patch v1.2 - Pass parser-xml-close-comment.html again Nice!
Patrick Angle
Comment 7 2022-02-02 08:33:37 PST
Created attachment 450645 [details] Patch v1.3 - Review nit
EWS
Comment 8 2022-02-02 14:14:16 PST
Committed r288996 (246715@main): <https://commits.webkit.org/246715@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450645 [details].
WebKit Commit Bot
Comment 9 2022-02-04 07:44:58 PST
Re-opened since this is blocked by bug 236141
Patrick Angle
Comment 10 2022-03-22 09:31:46 PDT
Created attachment 455382 [details] Patch v1.4 - Fix handling multi-line comment and string error cases
Patrick Angle
Comment 11 2022-03-22 11:00:19 PDT
Comment on attachment 455382 [details] Patch v1.4 - Fix handling multi-line comment and string error cases Oops - looks like this patch doesn't actually include the new test file 🤦🏻‍♂️
Patrick Angle
Comment 12 2022-03-22 11:05:38 PDT
Created attachment 455396 [details] Patch v1.4a - Fix handling multi-line comment and string error cases
Yusuke Suzuki
Comment 13 2022-03-22 11:23:53 PDT
Comment on attachment 455396 [details] Patch v1.4a - Fix handling multi-line comment and string error cases View in context: https://bugs.webkit.org/attachment.cgi?id=455396&action=review r=me > Source/JavaScriptCore/ChangeLog:7 > + Can you also add JSTests/stress test which caused the crash for the previous patch? (To ensure that this new one is working).
Patrick Angle
Comment 14 2022-03-22 13:45:58 PDT
Created attachment 455422 [details] Patch v1.5 - Add JSTests cases
EWS
Comment 15 2022-03-23 09:41:23 PDT
Committed r291746 (248778@main): <https://commits.webkit.org/248778@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455422 [details].
Yusuke Suzuki
Comment 16 2022-03-24 17:28:35 PDT
*** Bug 221548 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 17 2022-03-24 17:34:33 PDT
*** Bug 213873 has been marked as a duplicate of this bug. ***
Yusuke Suzuki
Comment 18 2022-04-26 12:40:21 PDT
*** Bug 239491 has been marked as a duplicate of this bug. ***
Patrick Angle
Comment 19 2022-09-20 13:23:45 PDT
*** Bug 244814 has been marked as a duplicate of this bug. ***
Alexey
Comment 20 2023-09-12 16:00:44 PDT
Has it landed on any stable version yet?
Note You need to log in before you can comment on or make changes to this bug.