| Summary: | No breakpoints hit on github.com, and some are invalid | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | Web Inspector | Assignee: | Dean Jackson <dino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | amakhrov, chi187, commit-queue, dan, evan.exe, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, michal64128, msaboff, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=239134 | ||
| Bug Depends on: | 236141 | ||
| Bug Blocks: | |||
| Attachments: | |||
Created attachment 449986 [details]
Patch v1.0 - Needs tests
Created attachment 450500 [details]
Patch v1.1 - Added tests, fixed cases where string token start offset was incorrect.
Created attachment 450502 [details]
Patch v1.2 - Pass parser-xml-close-comment.html again
Comment on attachment 450502 [details] Patch v1.2 - Pass parser-xml-close-comment.html again View in context: https://bugs.webkit.org/attachment.cgi?id=450502&action=review r=me > Source/JavaScriptCore/parser/Lexer.cpp:2493 > } I know it is pre-existing, but this }'s place is wrong, so can you unindent one level? Comment on attachment 450502 [details]
Patch v1.2 - Pass parser-xml-close-comment.html again
Nice!
Created attachment 450645 [details]
Patch v1.3 - Review nit
Committed r288996 (246715@main): <https://commits.webkit.org/246715@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450645 [details]. Re-opened since this is blocked by bug 236141 Created attachment 455382 [details]
Patch v1.4 - Fix handling multi-line comment and string error cases
Comment on attachment 455382 [details]
Patch v1.4 - Fix handling multi-line comment and string error cases
Oops - looks like this patch doesn't actually include the new test file 🤦🏻♂️
Created attachment 455396 [details]
Patch v1.4a - Fix handling multi-line comment and string error cases
Comment on attachment 455396 [details] Patch v1.4a - Fix handling multi-line comment and string error cases View in context: https://bugs.webkit.org/attachment.cgi?id=455396&action=review r=me > Source/JavaScriptCore/ChangeLog:7 > + Can you also add JSTests/stress test which caused the crash for the previous patch? (To ensure that this new one is working). Created attachment 455422 [details]
Patch v1.5 - Add JSTests cases
Committed r291746 (248778@main): <https://commits.webkit.org/248778@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455422 [details]. *** Bug 221548 has been marked as a duplicate of this bug. *** *** Bug 213873 has been marked as a duplicate of this bug. *** *** Bug 239491 has been marked as a duplicate of this bug. *** *** Bug 244814 has been marked as a duplicate of this bug. *** Has it landed on any stable version yet? |
Created attachment 449962 [details] Screenshot 1. Go to github.com when not logged in (so you get the globe animation, not your dashboard). 2. Open the inspector, search for "getContext(" and put a breakpoint on the line with "Y = e.getContext(F, H);" 3. Put another breakpoint just below that, on the line with "const x = {". Notice that it is not resolved/enabled. 4. Reload the page. None of the breakpoints are hit.