Bug 235562

Summary: Constructing untaken LOG(Category, ...) arguments slow debug binaries down
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: Web Template FrameworkAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229664
https://bugs.webkit.org/show_bug.cgi?id=260884
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2022-01-25 02:06:11 PST 
Constructing untaken LOG(Category, ...) arguments slow debug binaries down 
Leads to case-by-case hacking around the problem, which leads to bugs (Why is this LOG(IPCMessages,..) not printed?

Should be consistent with RELEASE_LOG(Category, ...)
Comment 1 Kimmo Kinnunen 2022-01-25 02:18:10 PST 
Created attachment 449905 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-02-01 02:07:15 PST 
<rdar://problem/88318352>
Comment 3 EWS 2022-02-15 22:54:37 PST 
Committed r289879 (247317@main): <https://commits.webkit.org/247317@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449905 [details].