Bug 235560

Summary: Streams tests try to call ReadableStream.prototype.pipeThrough.call generically
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebCore Misc.Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235398    
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2022-01-24 23:57:06 PST 
Streams tests try to call ReadableStream.prototype.pipeThrough.call generically

ReadableStream methods are nowadays defined to accept only ReadableStream instances.
Tests sometimes assert that an exception is thrown. However, the exception being actually thrown is different.
Future testharness.js will check the exception and the test will fail.
Comment 1 Kimmo Kinnunen 2022-01-25 00:00:06 PST 
Created attachment 449901 [details]
Patch
Comment 2 youenn fablet 2022-01-25 00:45:12 PST 
Comment on attachment 449901 [details]
Patch

r=me, all these tests are older versions of tests that we run in LayoutTests/imported/w3c/web-platform-tests/streams folder/subfolders
Comment 3 EWS 2022-01-26 01:48:19 PST 
Committed r288611 (246430@main): <https://commits.webkit.org/246430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449901 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-26 01:49:17 PST 
<rdar://problem/88065943>