| Summary: | Support workspace builds in build-webkit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Elliott Williams
2022-01-24 17:10:51 PST
Created attachment 449884 [details]
Patch
Created attachment 449886 [details]
Patch
Comment on attachment 449886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449886&action=review r=me. I don't see how the Windows build failure can be caused by this. > Tools/Scripts/build-webkit:126 > + --[no-]use-workspace Use WebKit.xcworkspace and XCBuild (iOS and Mac only) AFAICT this affects watchOS and tvOS too. Created attachment 449943 [details]
Patch
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 449886 [details] > Patch > > > Tools/Scripts/build-webkit:126 > > + --[no-]use-workspace Use WebKit.xcworkspace and XCBuild (iOS and Mac only) > > AFAICT this affects watchOS and tvOS too. Good catch, I've changed this and a couple other Xcode-specific flags to say "Apple platforms only". (In reply to Elliott Williams from comment #5) > I've changed this and a couple other Xcode-specific flags to say > "Apple platforms only". This patch is ready to go, and shouldn't need additional review since it's a usage-text-only change. The windows build failure has sorted itself out, and the jsc-armv7 test failure appears to be a flake. Committed r288632 (246447@main): <https://commits.webkit.org/246447@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449943 [details]. |